Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnostification of gadget-common and introduction of GadgetEnvironments #173

Merged
merged 14 commits into from
Jun 12, 2024

Conversation

tbraun96
Copy link
Collaborator

@tbraun96 tbraun96 commented Jun 8, 2024

No description provided.

common/src/client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't moved to v2 yet, this is taking a bit longer than it likely needs to. @tbraun96 i really recommend shifting to jobs/v2 api soon. I'm not seeing it in this PR.

@tbraun96
Copy link
Collaborator Author

We haven't moved to v2 yet, this is taking a bit longer than it likely needs to. @tbraun96 i really recommend shifting to jobs/v2 api soon. I'm not seeing it in this PR.

Completely re-organizing and agnostifying the entire codebase after we decided on a model change is not easy. These PRs are indeed v2-related, since it will allow us to define the v2 calls seamlessly once complete. Without these PRs, we have no v2 potential

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
common/src/lib.rs Outdated Show resolved Hide resolved
environments/tangle/src/client.rs Outdated Show resolved Hide resolved
@tbraun96 tbraun96 merged commit cf517f0 into main Jun 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants