Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Veridise audit fixes #350

Merged
merged 45 commits into from
Sep 6, 2023
Merged

Veridise audit fixes #350

merged 45 commits into from
Sep 6, 2023

Conversation

drewstone
Copy link
Contributor

No description provided.

@drewstone
V-WBT-VUL-001: Public Function Allows Theft from VAnchor
e43f990
@drewstone
V-WBT-VUL-002: InsertTwo Functions may Overwrite Leaves
30d6a55
@drewstone
V-WBT-VUL-003: Replay Attack on Voting Signatures
1a72ea9
@drewstone
V-WBT-VUL-004: Unchecked Assumptions in hash11
61c39e3
@drewstone
V-WBT-VUL-004: Unchecked Assumptions in hash11 (just remove unused fu…
66a35d7 
…nctions)
@drewstone
V-WBT-VUL-005: Missing Checks Against SNARK_SCALAR_FIELD
7db7ed6
@drewstone
V-WBT-VUL-006: Incorrect Initialization in Membership Circuits
eaf4da3
@drewstone
V-WBT-VUL-007: Batch Voting May Change Voting Period in Middle of Vote
1cd8e9e
@drewstone
V-WBT-VUL-008: RateLimitedVAnchor allows larger withdrawals if no wit…
6fa592e 
…hdrawals occur for several days
@drewstone
V-WBT-VUL-009: Voting Results May Change On Vote Order
b938e53
@drewstone
V-WBT-VUL-010: Potential Problems with transfer
b088daa
@drewstone
V-WBT-VUL-011: Different Tokens may use Single Token Wrapper
5e913b5
@drewstone
V-WBT-VUL-012: Native Token Wrapping may Bypass Limit
5ffe9ee
@drewstone
V-WBT-VUL-013: Missing zeroLeaf check
b49dc05
@drewstone
V-WBT-VUL-014: Multiple Voting Periods in One Transaction If Session …
4541dca 
…Length Is 0
@drewstone
V-WBT-VUL-015: Voting disabled due to default value of averageSession…
70cb14c 
…LengthInMillisecs
@drewstone
V-WBT-VUL-016: Validate Calldata Has Correct Size
ec1623c
@drewstone
V-WBT-VUL-017: Missing Address Checks in VAnchorVerifier
5af8639
@drewstone
V-WBT-VUL-018: Missing Address Checks in TxProofVerifier
b0ed4f1
@drewstone
V-WBT-VUL-019: Invalid Argument Reverts with Invalid Proof
ad7efb8
@drewstone
V-WBT-VUL-020: Unchecked Bytes Length in decodeRoots
5b0f096
@drewstone
V-WBT-VUL-022: External Function Should Be Public
487c4f5
@drewstone
V-WBT-VUL-023: Batch Voting Tallying Logic Ambiguous due to Ownership…
8ff257d 
… Transfer in the Middle
@drewstone
V-WBT-VUL-024: Missing Address Check in LinkableAnchor
4d3675a
@drewstone
V-WBT-VUL-025: nthZero returns invalid leafs for out-of-bounds batchL…
b530d4f 
…evels
@drewstone
V-WBT-VUL-026: Create2 Compatibility Problems
3ad90b5
@drewstone
V-WBT-VUL-027: Hardcoded Address Compatibility Problems
89dbde4
@drewstone
V-WBT-VUL-028: No Depth to Voter Merkle Tree
371bf59
@drewstone
V-WBT-VUL-029: Use Constant Instead of Magic Number
4035d66
@drewstone
V-WBT-VUL-030: Tree Height not Validated
288681b
@drewstone drewstone merged commit eeb4fc7 into main Sep 6, 2023
5 of 6 checks passed
@drewstone drewstone deleted the drew/veridise-audit branch September 6, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@drewstone