Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIFlash does not handle spaces in Python path #65

Closed
webbcam opened this issue Feb 9, 2019 · 0 comments
Closed

TIFlash does not handle spaces in Python path #65

webbcam opened this issue Feb 9, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@webbcam
Copy link
Owner

webbcam commented Feb 9, 2019

TIFlash fails to launch JS script when the Python installation path contains a space.

Context

On Windows machine, when installing Python for "All Users", the default installation location is:
C:\Program Files\Python37 or C:\Program Files (x86)\Python37
Currently TIFlash does not wrap the Python installation path in quotes when passing to the main.js script.

Expected result

TIFlash should handle pass the Python installation path correctly even when including a space.

Possible Fix

In the call_dss() (in utils/dss.py) wrap the 'main_js' and 'cwd' in quotes before placing in the command for passing to subprocess.


@webbcam webbcam added the bug Something isn't working label Feb 9, 2019
@webbcam webbcam self-assigned this Feb 9, 2019
@webbcam webbcam closed this as completed in 41d3541 Feb 9, 2019
webbcam added a commit that referenced this issue Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant