Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Have TIFlash use CCS installation version of board_ids.json for default device lookup #86

Open
webbcam opened this issue Aug 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@webbcam
Copy link
Owner

webbcam commented Aug 22, 2019

Describe the bug
Currently TIFlash uses a provided version of board_ids.json for device-serno look up by default. This causes us to have to maintain this file and keep it up to date with every new device. Instead, we should remove the provided board_ids.json file. TIFlash should first load the board_ids.json file provided with CCS installation. Then if a board_ids.json file exists in the ~/.tiflash folder (in case user wants to place a custom file to use), and load these entries into the lookup table. Any duplicate keys will be replaced by the custom file.

Possible Fix

  1. Remove the board_ids.json file provided with tiflash
  2. Have get_devicexml_from_serno() first load the provided board_ids.json file provided in CCS installation. Then if a "board_ids.json" file exist in ~/.tiflash folder, this file will be loaded into the same dictionary; updating/replacing any duplicate entries.
@webbcam webbcam added the bug Something isn't working label Aug 22, 2019
webbcam added a commit that referenced this issue Oct 16, 2019
bug-#86 fix for board_ids.json file only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant