Use new og-image service for episode previews #4
Conversation
| const metaTags = [ | ||
| { name: "title", content: title }, | ||
| { | ||
| name: "keywords", | ||
| content: | ||
| "webbidevaus, web dev, podcast, react, node, typescript, javascript", | ||
| }, | ||
| { | ||
| name: "description", | ||
| content: description, | ||
| }, | ||
| { property: "og:title", content: title }, | ||
| { property: "og:description", content: description }, | ||
| { property: "og:url", content: url }, | ||
| { property: "og:image", content: coverUrl }, | ||
| { property: "og:type", content: "website" }, | ||
| { property: "twitter:title", content: title }, | ||
| { property: "twitter:description", content: description }, | ||
| { property: "twitter:url", content: url }, | ||
| { property: "twitter:image", content: coverUrl }, | ||
| { property: "twitter:card", content: "summary_large_image" }, | ||
| ]; |
There was a problem hiding this comment.
Nää ei ollu ollenkaa käytössä 😬 oli unused variable
There was a problem hiding this comment.
Käytännössä noi taitaa olla kuitenkin kaikki noissa metatageissa, eli olisko tää peruja jostain vanhasta koodista
There was a problem hiding this comment.
Joo kattelin tuolla netlifypreviewissä mut unohin tulla kommentoimaan takas, että kyl ne jotenkin sinne tosiaan valuu.
components/Layout.tsx
Outdated
| const coverUrl = `https://og-webbidevaus.vercel.app/${encodeURIComponent( | ||
| `**Jakso ${episode.number}**: ${episodeTitleWithoutNumber(episode.title)}` | ||
| )}?theme=${episode.number % 2 === 0 ? "light" : "dark"}&md=1&fontSize=100px`; |
There was a problem hiding this comment.
Tätä saa varmaan just sellaseks teemattua kun haluaa? Mietin että vois ainakin jotain väriä laittaa josain kohtaa.
There was a problem hiding this comment.
Lisäks tuo ** ei näytä boldaavan tekstiä vaan tulee ihan sellaisenaan
There was a problem hiding this comment.
Ah pentele, pitää siirtää noi tähdet ton encodeUriComponent-kutsun ulkopuolelle
No description provided.