Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom xdata #18

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Remove custom xdata #18

merged 1 commit into from
Apr 18, 2023

Conversation

dmandrade
Copy link
Member

Remove custom xdata to prevent conflict with action tooltip

Resolve #14

Remove custom xdata to prevent conflict with action tooltip
@dmandrade dmandrade added the bug Something isn't working label Apr 18, 2023
@dmandrade dmandrade merged commit f692b19 into main Apr 18, 2023
@chosten
Copy link

chosten commented Apr 18, 2023

I'm not sure that it will work if you put a quote in the copyable or the success notification title.
Shouldn't you escape them?
Maybe like this: 'x-on:click' => new HtmlString('window.navigator.clipboard.writeText('.json_encode($this->getCopyable()).'); $tooltip('.json_encode($this->getSuccessNotificationTitle()).');')

@dmandrade
Copy link
Member Author

I returned the escape I had using Js::from() on pr #21

@chosten
Copy link

chosten commented Apr 19, 2023

Thank you, I think it's safer.

@dmandrade
Copy link
Member Author

Any problem you can open another issue or a pr

@dmandrade dmandrade deleted the fix-tooltip-button-action branch January 2, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table action not working with tooltip
2 participants