Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate web server allows anyone to POST to sendmessage.php without logging in #1929

Closed
chuushi opened this issue Apr 15, 2016 · 1 comment

Comments

@chuushi
Copy link

chuushi commented Apr 15, 2016

I have the dynmap web server run on lighttpd in order to get the SSL support. Everything is internal.

My dynmap class configuration is made so: (omitted irrelevant portions)

  - class: org.dynmap.JsonFileClientUpdateComponent
    writeinterval: 1
    allowwebchat: true
    webchat-interval: 0
    hidewebchatip: true
    use-player-login-ip: false
    require-player-login-ip: false
    block-banned-player-chat: true
    # Require login for web-to-server chat (requires login-enabled: true)
    webchat-requires-login: true
    # If set to true, users must have dynmap.webchat permission in order to chat
    webchat-permissions: true
    # Limit length of single chat messages
    chatlengthlimit: 256
    hidenames: false

I assumed setting webchat-requires-login to true requires users to be logged on, and the dynmap uses browser session name to match the username with the messages. However, when I tried making a POST request to standalone/sendmessage.php manually on a different browser, it displayed "web-###" as the sender. I expected to get an error for trying to send a message while not logged in and/or no message output at all.

@chuushi chuushi changed the title Separate web server allows anyone to use webchat without logging in Separate web server allows anyone to POST to sendmessage.php without logging in Apr 15, 2016
@wioxjk
Copy link

wioxjk commented Jul 8, 2016

Have your tried:
use-player-login-ip: true
require-player-login-ip: true
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants