Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFrames become non-interactive #53

Closed
arpanmukherjee1 opened this issue Jul 28, 2015 · 6 comments
Closed

IFrames become non-interactive #53

arpanmukherjee1 opened this issue Jul 28, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@arpanmukherjee1
Copy link

@Lochemage,

While using IFRAMES docked panels become non-interactive due to div with wcIFrameFocus.

screen

Ref screenshot: the iframe panel on the right is not getting focus due to below div.

@Lochemage
Copy link
Contributor

@arpanmukherjee1

iFrames steal mouse input such as mouse drag events from reaching wcDocker, without the drag events, if you try to move a panel and dock it somewhere over the iFrame it causes problems. The solution was to cover up the iFrame with some element that blocks the iFrame from stealing mouse focus.

However, the wcIFrameFocus element should always be set to display: none except in very specific situations where I need to have mouse input. I see that yours seems to be stuck on display: block mode. Does clicking in that iFrame not cause the focus element to hide itself again?

Unfortunately, I've tried a number of actions but I can't seem to reproduce this, could you list more specifically what actions you took to get this?

@Lochemage Lochemage added the bug label Jul 28, 2015
@Lochemage Lochemage added this to the 3.0.0 milestone Jul 28, 2015
@Lochemage Lochemage self-assigned this Jul 28, 2015
@arpanmukherjee1
Copy link
Author

Ah, I get why the wcIFrameFocus is required.

To reproduce the issue: In your demo site

  1. close all panes except tutorial panel and control panel
  2. add another tutorial panel
  3. make it floating and then dock it on the right (or any other) side of the existing panel.

I tried the steps and reproduced the bug.

I tried to debug the code and __updateFrame() is reporting the panel as unfocused, focus is false.
ref iframe.js line# 260. And yes you are correct, clicking the IFrame does not hide the focus panel.

@Lochemage
Copy link
Contributor

@arpanmukherjee1

Thank you for the detailed instructions, I am able to reproduce this bug now.

I will have some time later tonight to look into it, I'll keep you updated!

@arpanmukherjee1
Copy link
Author

@Lochemage
Welcome. Sounds good to me, thanks.

Lochemage added a commit that referenced this issue Jul 29, 2015
@Lochemage
Copy link
Contributor

@arpanmukherjee1

Try it out now, I believe I have made it better than before!

@arpanmukherjee1
Copy link
Author

@Lochemage
It's working as expected. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants