Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Authentication #13

Merged
merged 11 commits into from Apr 26, 2014
Merged

Basic Authentication #13

merged 11 commits into from Apr 26, 2014

Conversation

bencevans
Copy link
Contributor

No description provided.

@bencevans
Copy link
Contributor Author

Currently there's no tests, this is because #14 is required to access another instance of app with different config.

@bencevans
Copy link
Contributor Author

This is ready for review and merge @webcast-io/developers!

@paulbjensen
Copy link
Contributor

I tried it yesterday evening, but running npm start exited soon after with no stack. I had put the auth config in as well.

@bencevans
Copy link
Contributor Author

Shall have a look in 10, I probably need to update the start command with
bin/jobukyu
On 3 Apr 2014 09:02, "Paul Jensen" notifications@github.com wrote:

I tried it yesterday evening, but running npm start exited soon after
with no stack. I had put the auth config in as well.

Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-39422799
.

@bencevans
Copy link
Contributor Author

Should work now @paulbjensen

paulbjensen added a commit that referenced this pull request Apr 26, 2014
@paulbjensen paulbjensen merged commit a7809b9 into master Apr 26, 2014
@bencevans bencevans deleted the feature/basic-auth branch April 26, 2014 13:26
@paulbjensen
Copy link
Contributor

Thanks Ben. I'm going to update queue and the workers tonight. I'll take care of Axisto Live/Attendee.io workers, could you let me know of any other workers (webcast.io) I'll need to update? Thanks.

@bencevans
Copy link
Contributor Author

Awesome. There's also one on the staging server for webcast
On 26 Apr 2014 14:44, "Paul Jensen" notifications@github.com wrote:

Thanks Ben. I'm going to update queue and the workers tonight. I'll take
care of Axisto Live/Attendee.io workers, could you let me know of any other
workers (webcast.io) I'll need to update? Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-41469062
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants