Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

bug: When using github app external links don't open in browser #849

Closed
Naatan opened this issue May 14, 2020 · 2 comments
Closed

bug: When using github app external links don't open in browser #849

Naatan opened this issue May 14, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Naatan
Copy link

Naatan commented May 14, 2020

Bug Report

Specifications:

  • App Version: 8.14.1
  • OS (macOS, Windows, Linux): macOS

Description:
When opening a link on github (in this case a circleci link on a failed integration) it opens it inside the app window, rather than in my default browser.

Steps to Reproduce:
Click a link on github that goes to an external site

@quanglam2807 quanglam2807 added the bug Something isn't working label May 16, 2020
@quanglam2807
Copy link
Member

Thank you for reporting this. The link is not opened in browser because GitHub doesn't set the link to open in new tab. At the moment, WebCatalog detects external links and opens them in browser ONLY the link is opened with target='_blank'. I'm afraid forcing all external links, including links that normally are opened in the same browser tab, to open in new window/externally might break web apps.

Anyway, I'll attempt to force this behavior in the next update. Hopefully, it won't break anything.

@quanglam2807
Copy link
Member

Fixed with webcatalog/neutron#6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants