BinanceApi::klines() and BinanceApi::aggTrades() seem buggy #11

Creckle · 2018-01-13T13:35:30Z

Line 232 in db3378e

if (!optionKey.equals("startTime") || !optionKey.equals("endTime")) {

change 'or' to 'and'
same goes for

Line 181 in db3378e

if (!optionKey.equals("fromId") ||

and the next line

wcrbrm · 2018-01-13T14:58:38Z

@Creckle thanks for your feedback.

wcrbrm · 2018-01-13T15:31:24Z

the fix was included in Release 1.0.8, just pushed it on Maven

wcrbrm pushed a commit that referenced this issue Jan 13, 2018

#11 klines and aggTrades fix and test coverage with options

6ac18ec

wcrbrm closed this as completed Jan 13, 2018

Provide feedback