[~FEATURE] Concatenate core js files #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2015 09:23
|
Just as I expected I ran into some errors when prototype was uglified. The reason is that uglifyjs renames some super global variable names of prototype which some function depends upon. The solution is very simple: Just don't do it. Lucky for me, uglifyjs comes with an option that lets me skip this process. As a result the core files are still minified with all the needed functions (and global variable names) still intact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #100 and addresses #111.
The most frequently used Magento core JS files are concatenated into one file, minimizing HTTP requests. The uglification processs might destroy some prototype function, I think I've stumbled accross a blog post somewhere, but this is highly speculative and has not been tested. So far, at least product page still works. :)