Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live.bilibili.com - Video does not play smoothly #107388

Closed
webcompat-bot opened this issue Jul 14, 2022 · 5 comments
Closed

live.bilibili.com - Video does not play smoothly #107388

webcompat-bot opened this issue Jul 14, 2022 · 5 comments
Assignees
Labels
browser-firefox diagnosis-priority-p1 engine-gecko The browser uses the Gecko rendering engine priority-critical priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Jul 14, 2022

URL: https://live.bilibili.com/6

Browser / Version: Firefox 102.0
Operating System: Windows 10
Tested Another Browser: Yes Chrome

Problem type: Something else
Description: live video play on this page so much not smoothly compared with Google Chrome
Steps to Reproduce:
I try to watch live video no the page first time by Firefox. Live video play on this page so much not smoothly compared with Google Chrome.

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Jul 14, 2022
@webcompat-bot webcompat-bot added this to the needstriage milestone Jul 14, 2022
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Jul 14, 2022
@webcompat-bot webcompat-bot changed the title In the moderation queue. live.bilibili.com - see bug description Jul 14, 2022
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-critical and removed browser-fixme This requires manual assignment for the browser name action-needsmoderation The moderation has not yet been completed labels Jul 14, 2022
@softvision-oana-arbuzov
Copy link
Member

Thanks for the report, I was able to reproduce the issue. The video plays with a bit of lag and also the scrolling of the text over the video is not smooth.
image

I've recorded a performance profile: https://share.firefox.dev/3aEl1yy

Affected area:

<div style="position: absolute; bottom: 0px; width: 100%; z-index: 13;" class="web-player-controller-wrap" id="web-player-controller-wrap-el">
</div>

Note: The issue is not reproducible on Chrome.

Tested with:
Browser / Version: Firefox Nightly 104.0a1 (2022-07-14), Firefox Release 102.0.1
Operating System: Windows 10 Pro

Moving to Needsdiagnosis for further investigation.

[qa_28/2022]

@softvision-oana-arbuzov softvision-oana-arbuzov added priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. labels Jul 15, 2022
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title live.bilibili.com - see bug description live.bilibili.com - Video does not play smoothly Jul 15, 2022
@wisniewskit
Copy link
Member

I see that ~24% of the time in Oana's profile is spent in Element.getBoundingClientRect, from this rough stack trace of their JS:
r.prototype.start -> e.prototype.getText -> e.prototype.textRender => e.prototype.getDivInfo

So this might be related to our current investigation of getBoundingClientRect.

Otherwise, smaller chunks of time are spent in Element.scrollHeight (~6.2%) doing reflows/style computations every frame of video (t.prototype.nextFrame), and in Element.clientWidth (~3%) while handling events, which I would guess is while moving the mouse over the text.

So let's revisit this as our investigation of getBoundingClientRect progresses.

@wisniewskit
Copy link
Member

@softvision-raul-bucata this seems to be working fine for me now, could you confirm if you can still reproduce the performance issue on Windows 10?

@wisniewskit wisniewskit added the needsinfo-raul ping @softvision-raul-bucata label Apr 24, 2023
@softvision-raul-bucata
Copy link

softvision-raul-bucata commented Apr 25, 2023

@wisniewskit I can confirm that the issue no longer reproduces.

Tested with:

Browser / Version: Firefox Nightly 114.0a1 (2023-04-24) (64-bit)
Operating System: Windows 10 PRO x64

[inv_17/2023]

@wisniewskit
Copy link
Member

Ok, then let's close this for now. If it ever becomes reproducible again, we can reopen the bug or file a new one.

@wisniewskit wisniewskit closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
@softvision-raul-bucata softvision-raul-bucata removed the needsinfo-raul ping @softvision-raul-bucata label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox diagnosis-priority-p1 engine-gecko The browser uses the Gecko rendering engine priority-critical priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Projects
None yet
Development

No branches or pull requests

6 participants