Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.digital.go.jp - SVG is not displayed on upper-left side of the site #109008

Closed
myakura opened this issue Aug 12, 2022 — with webcompat-app · 7 comments
Closed

www.digital.go.jp - SVG is not displayed on upper-left side of the site #109008

myakura opened this issue Aug 12, 2022 — with webcompat-app · 7 comments
Assignees
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-critical The site or core functionality is unusable, or you would probably open another browser to use it.
Milestone

Comments

@myakura
Copy link

myakura commented Aug 12, 2022

URL: https://www.digital.go.jp/

Browser / Version: Firefox 104.0
Operating System: Mac OS X 10.15
Tested Another Browser: Yes Chrome

Problem type: Design is broken
Description: Images not loaded
Steps to Reproduce:
Steps to reproduce:

  1. go to the site
  2. look at the the upper-left side of the site
  3. check if there is an image that is the same as the content on https://www.digital.go.jp/assets/images/Digital_Agency_Logo_Black_JA.svg

Actual result:

In Firefox there's no image rendered on screen.

View the screenshot Screenshot
Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Aug 12, 2022
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine labels Aug 12, 2022
@myakura
Copy link
Author

myakura commented Aug 12, 2022

I made a minimal reproducible test case.
https://myakura.github.io/test--flexbox-descendant-svg/test-vb.html (source code)

It seems Firefox doesn't calculate the size of an SVG image without width and height attributes if it is placed as a descendant of a flexbox.

@myakura
Copy link
Author

myakura commented Aug 12, 2022

Ah it looks like a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1521882 ?

@myakura
Copy link
Author

myakura commented Aug 12, 2022

adding Chrome screenshot for comparison.

View the screenshotScreenshot

@softvision-oana-arbuzov softvision-oana-arbuzov added the os-mac Issues only happening on macOS. label Aug 12, 2022
@softvision-oana-arbuzov
Copy link
Member

Thanks for the report, I was able to reproduce the issue.
image

Affected area:

<a class="header__title" href="/">
  <img src="/assets/images/Digital_Agency_Logo_Black_JA.svg" alt="デジタル庁">
  <span class="u-visually-hidden">ホーム</span>
</a>

Tested with:
Browser / Version: Firefox Nightly 105.0a1 (2022-08-11), Firefox Release 103.0.2
Operating System: Windows 10 Pro

Moving to Needsdiagnosis for further investigation.
@ksy36 can you confirm it is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1521882

[qa_32/2022]

@softvision-oana-arbuzov softvision-oana-arbuzov changed the title www.digital.go.jp - design is broken www.digital.go.jp - SVG is not displayed on upper-left side of the site Aug 12, 2022
@softvision-oana-arbuzov softvision-oana-arbuzov added priority-normal severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. labels Aug 12, 2022
@ksy36
Copy link
Contributor

ksy36 commented Aug 19, 2022

Thanks for your analysis @myakura. This looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1409529, since the image in question has svg as its source attribute and its parent is a flex container. The testcase in comment 6 is similar to your testcase.

P.S. I've noticed that in your test case the image is not showing in both Chrome and Firefox because width: 100%; is missing on the image tag (they have this style rule on the website). Once I add it, the image appears in Chrome, but not in Firefox, and starts matching the behavior on the site.

@ksy36 ksy36 modified the milestones: needsdiagnosis, duplicate Aug 19, 2022
@ksy36 ksy36 added action-needssitepatch This web bug needs a GoFaster site patch. and removed status-needsinfo-ksy36 ping @ksy36 labels Aug 19, 2022
@ksy36
Copy link
Contributor

ksy36 commented Aug 19, 2022

We could add a sitepatch here since this is quite popular site. Setting width: 140px for the image in question makes the svg appear.

@karlcow karlcow closed this as completed Aug 30, 2022
@ksy36 ksy36 removed the action-needssitepatch This web bug needs a GoFaster site patch. label Apr 27, 2023
@ksy36
Copy link
Contributor

ksy36 commented Apr 27, 2023

This is now working, removing the sitepatch label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-critical The site or core functionality is unusable, or you would probably open another browser to use it.
Projects
None yet
Development

No branches or pull requests

5 participants