Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.ipeen.com.tw - The Share to FB link is not working #11768

Closed
softvision-sergiulogigan opened this issue Oct 6, 2017 · 3 comments
Closed

Comments

@softvision-sergiulogigan

URL: http://content.ipeen.com.tw/tastenews/962

Browser / Version: Firefox Mobile Nightly 58.0a1 (2017-10-05)
Operating System: Samsung Galaxy S7 (Android 7.0) - 1440 x 2560 pixels (~534 ppi pixel density)
Tested Another Browser: Yes

Problem type: Site is not usable
Description: The Share to FB link is not working
Steps to Reproduce:

  1. Navigate to: http://content.ipeen.com.tw/tastenews/962
  2. Scroll to the "分享至facebook" button.
  3. Tap it.

Expected Behavior:
A tab is opened and the article can be shared.

Actual Behavior:
2 tabs are opened, and shortly after, one of them is closed. A blank tab is displayed.

Notes:

  1. The issue is not reproducible on Firefox 56.0 Release (Mobile).
  2. The issue is not reproducible on Chrome (Mobile) 61.0.3163.98.

Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan

sv; country: tw
Screenshot Description

From webcompat.com with ❤️

@softvision-sergiulogigan
Copy link
Author

Firefox WebIDE says:
image

Chrome remote device Inspector says:
image

@softvision-sergiulogigan softvision-sergiulogigan changed the title content.ipeen.com.tw - site is not usable content.ipeen.com.tw - The Share to FB link is not working Oct 6, 2017
@karlcow karlcow added this to the needsdiagnosis milestone Oct 30, 2017
@softvision-sergiulogigan
Copy link
Author

The object code is:

<a href="javascript:void(window.open('http://www.facebook.com/share.php?u='.concat(encodeURIComponent(location.href)) ));" target="blank" class="sharefb">分享至facebook</a>

If the target="blank" part is deleted, the button works as expected.

@MDTsai
Copy link

MDTsai commented Jan 17, 2018

They uses location.href , replace with some other URL then works. So it's the problem using blank as the bug https://bugzilla.mozilla.org/show_bug.cgi?id=836567
It's we don't follow the HTML5 spec of javascript: URL as @freesamael comment. Close as duplicate.

@MDTsai MDTsai closed this as completed Jan 17, 2018
@MDTsai MDTsai modified the milestones: needsdiagnosis, duplicate Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants