Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.google.com - Tapping on the account icon doesn't do anything. #17562

Closed
webcompat-bot opened this issue Jul 3, 2018 · 4 comments
Closed
Labels
browser-firefox-mobile priority-critical type-GWS-interop Google properties interoperability testing
Milestone

Comments

@webcompat-bot
Copy link

URL: https://www.google.com/search?source=hp

Browser / Version: Firefox Mobile 63.0
Operating System: Android 4.4.4
Tested Another Browser: Unknown

Problem type: Site is not usable
Description: account icon at the top right is not working
Steps to Reproduce:
alresdy logged in to a google account go to google search. then tsp the icon. nothing is happening

From webcompat.com with ❤️

@karlcow
Copy link
Member

karlcow commented Jul 3, 2018

I reported this.

@karlcow karlcow modified the milestones: needstriage, needsdiagnosis Jul 3, 2018
@karlcow karlcow added type-GWS-interop Google properties interoperability testing status-needsinfo-denschub ping @denschub labels Jul 3, 2018
@karlcow karlcow changed the title www.google.com - site is not usable www.google.com - Tapping on the account icon doesn't do anything. Jul 3, 2018
@wisniewskit
Copy link
Member

Confirmed. No output is being displayed in the console when tapping on the icon, though the remote devtool's inspector does show that it's ultimately a link tag with a click event listener attached to it. This listener is on line 78 of the main HTML page, a highly-minified <script> tag.

Installing the Tinker Tester Developer Spy add-on on my phone and configuring its DOM Events section to detect whenever a click event is added or fired on an a.gb_R, shows that there is indeed a click listener added while the page loads, but no such events are actually fired when tapping on the icon.

However, if I double the width of the anchor element, I can click on the parts that don't have the image of my account icon covering them. It turns out that the span element inside of the anchor element is somehow preventing clicks from being propagated up to it.

After playing around in the devtools for a while with the various styles being applied to the span, I hit upon the issue. Toggling it as :active in the devtools reveals the style rule that is the problem:

.gb_db:active::after {
  background:rgba(0,0,0,.1);
  -webkit-border-radius:50%;
  border-radius:50%;
  content:'';
  display:block;
  height:100%
}

Removing it renders the link as tappable again. I created a reduced test-case, and it appears that this may be a Fennec bug, or a Gecko bug on touchscreens (since clicking on the content works, just not tapping on it). I've filed bz1473108 with the test-case to investigate this.

@wisniewskit
Copy link
Member

Unfortunately it appears that the tier-1 Google page (with UA spoof) still doesn't allow for tapping on the icon, even though bz1473108 was just fixed. We'll need to resume investigations here.

@wisniewskit wisniewskit reopened this Oct 11, 2018
@karlcow
Copy link
Member

karlcow commented Nov 12, 2018

@wisniewskit this seems to be working for me.

@karlcow karlcow closed this as completed Nov 12, 2018
@karlcow karlcow modified the milestones: needsdiagnosis, worksforme Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile priority-critical type-GWS-interop Google properties interoperability testing
Projects
None yet
Development

No branches or pull requests

3 participants