Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.ebparks.org - layout is messed up #1838

Closed
dholbert opened this issue Oct 25, 2015 · 4 comments
Closed

www.ebparks.org - layout is messed up #1838

dholbert opened this issue Oct 25, 2015 · 4 comments

Comments

@dholbert
Copy link

URL: http://www.ebparks.org/activities/camping
Browser / Version: Firefox 44.0
Operating System:
Problem type: Layout is messed up

Steps to Reproduce
0) Be using Firefox on Android, or firefox on Desktop with a mobile UA & a phone-sized browser window. (Tested both.)

  1. Navigate to: http://www.ebparks.org/activities/camping
  2. Scroll down to the photos, towards the bottom. (and/or try to scroll horizontally)

Expected Behavior:

  • Photos should scale down to fit the viewport width.
  • There should be no ability to scroll horizontally (because nothing should overflow off to the right.

Actual Behavior:

  • Photos run off the right side of the page.
  • As a result, the page is scrollable horizontally (but the photos are the only things overflowing into the off-screen area)
@dholbert
Copy link
Author

Screenshot of photos running off the right side

Screenshot of site being awkwardly scrollable horizontally, due to photo overflow

@dholbert
Copy link
Author

(For comparison: in Chrome for Android, the photos simply scale down to fit the page width.)

@dholbert
Copy link
Author

INFO FROM DEVTOOLS: It looks like...
(1) The images are inside of a

which has "max-width: 100% and "width: 100%". (But tables are free to ignore their "width" attribute if their contents are wider than that.)

(2) The img elements themselves have "max-width: 100%" (that's as-applied to the width of their

, not the width of the table) This doesn't impact our intrinsic-width calculation for the table cell based on the images, though, I think due to https://bugzilla.mozilla.org/show_bug.cgi?id=823483 .

(3) If I manually give the img elements "width: 100%" (or "200%" or any percent value really), then they don't overflow. I believe this is because this influences our intrinsic-size-calculation which we perform to size the table based on its cells' desired sizes.

So I think our suggested fix might be to do (3)...

@karlcow
Copy link
Member

karlcow commented Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants