weather.com - see bug description

[dhdurgee]

URL: https://weather.com/weather/hourbyhour/l/20877:4:US
Browser / Version: Firefox 43.0
Operating System: Ubuntu
Problem type: Something else - I'll add details below

Steps to Reproduce

1. Navigate to: https://weather.com/weather/hourbyhour/l/20877:4:US
2. …

Expected Behavior: should display current hour-by-hour forecast

Actual Behavior: "upgrade now" message overlays display and cannot be closed

From webcompat.com with ❤️

[dhdurgee]

Minor clarification, actual browser is SeaMonkey 2.40 here. I am using PrefBar to spoof the UA as FireFox 43, which generally avoids issues such as the above.

[adamopenweb]

Thanks for the report @dhdurgee! As mentioned the site is using user agent sniffing to try to detect the browser and displays an overlay when the detection fails. The overlay does not want to close in Gecko and when we check the console we see:
TypeError: event.srcElement is undefined

event.srcElement is non-standard and unsupported in Gecko.
https://developer.mozilla.org/en-US/docs/Web/API/Event/srcElement

It appears a few times on the site, but this looks to be the offender here:
https://weather.com/sites/all/modules/custom/angularmods/assets/older_browser_overlay/older_browser_overlay.js

[adamopenweb]

event.target can be used instead of event.srcElement
or
(event.target || event.srcElement)
if they're worried about supporting older versions of IE.

Switching to needscontact.

[adamopenweb]

Maybe @twc-rhedin or @vadlamak can help out with this one?

[adamopenweb]

I can't get this to reproduce on my end anymore, I think it's fixed. @dhdurgee can you confirm?