Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Guess Who pictures should be contained in the tiles - codepen.io - design is broken #31092

Closed
kbrosnan opened this issue May 14, 2019 · 7 comments
Labels
browser-firefox depends-gecko issue caused by Gecko engine-gecko The browser uses the Gecko rendering engine priority-important
Milestone

Comments

@kbrosnan
Copy link

URL: https://codepen.io/ruidovisual/pen/KoRgGR

Browser / Version: Firefox 68.0
Operating System: Windows 10
Tested Another Browser: Yes

Problem type: Design is broken
Description: The Guess Who pictures should be contained in the tiles
Steps to Reproduce:
Visit page

  • The tiles have odd angles
  • Poor gradient behind the board

Works fine in Edge 18 (EdgeHTML)

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone May 14, 2019
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-important labels May 14, 2019
@kbrosnan kbrosnan changed the title codepen.io - design is broken The Guess Who pictures should be contained in the tiles - codepen.io - design is broken May 14, 2019
@karlcow
Copy link
Member

karlcow commented May 14, 2019

From left to right: Firefox Nightly, Safari Tech Preview, Chrome Canary

Screenshot Description

@kbrosnan
Copy link
Author

kbrosnan commented May 14, 2019

Maybe then it is a Windows Graphics issue?
Screenshot_2019-05-14 Guess Who(3)

@kbrosnan
Copy link
Author

Filed 1551736. For screenshots producing a busted result. Checking to see if WebRender affects the bug as reported.

@karlcow
Copy link
Member

karlcow commented May 14, 2019

I don't think it's windows only because the screenshots I made are on macos and the issue is visible.

@karlcow
Copy link
Member

karlcow commented May 14, 2019

but indeed your screenshot is even weirder than the mac one.

@denschub
Copy link
Member

Okay, there is a lot going on in this bug.

The outer element, <form class="board"> has

transform: rotateX(30deg) translateX(10px);
transform-style: preserve-3d;

the element that's supposed to "stand up", <label class="card"> has

transform-origin: bottom left;
transform: rotateX(-45deg);

and something is fishy here. If we move the card up a few levels so that it is a direct child of the form, the card stands up correctly. As soon as there are other elements, the transform-style seems to no longer be in effect, which is odd. As a quick verification for my theory, we can add

.slots, .slot {
  transform-style: preserve-3d;
}

and yes indeed, the cards "stand up" now.

After a bit of digging, it turns out we already have a bug for that, but it may not be so simple. Firefox is passing a WPT here, but it seems like that test actually may be contradicting what the spec says, so that's fun.

More details and follow-up discussion links are available in bug 1362543. I have the strong feeling that this eventually results in a change inside Firefox, and since this is a report about a lab-example anyway, let's just go ahead and close this report as a duplicate of said Firefox issue.

@denschub denschub modified the milestones: needsdiagnosis, duplicate May 17, 2019
@denschub denschub added the depends-gecko issue caused by Gecko label May 17, 2019
@lock
Copy link

lock bot commented May 24, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser-firefox depends-gecko issue caused by Gecko engine-gecko The browser uses the Gecko rendering engine priority-important
Projects
None yet
Development

No branches or pull requests

4 participants