Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com - The "Sign in" button is not working #31274

Closed
webcompat-bot opened this issue May 17, 2019 · 5 comments
Closed

github.com - The "Sign in" button is not working #31274

webcompat-bot opened this issue May 17, 2019 · 5 comments
Labels
browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. type-css-flexbox
Milestone

Comments

@webcompat-bot
Copy link

URL: https://github.com/

Browser / Version: Firefox Mobile 68.0
Operating System: Android
Tested Another Browser: Yes

Problem type: Site is not usable
Description: can't click github sign in button
Steps to Reproduce:

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone May 17, 2019
@webcompat-bot webcompat-bot added browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical labels May 17, 2019
@cipriansv cipriansv added the severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. label May 20, 2019
@cipriansv cipriansv changed the title github.com - site is not usable github.com - The "Sign in" button is not working May 20, 2019
@cipriansv cipriansv modified the milestones: needstriage, needsdiagnosis May 20, 2019
@cipriansv
Copy link

Thanks for the report,
I was indeed able to reproduce the issue. The "Sign in" button is not working.

Tested with:
Browser / Version: Firefox Fenix 1.0.1920, Chrome Mobile 74.0.3729.157
Operating System: Huawei P10 (Android 8.0) - 1080 x 1920 pixels (~432 ppi pixel density)

This is the web page displayed in Firefox Fenix when tapping on the "Sign in" button:

signin

And this is the web page displayed in Chrome:

signinch

@reinhart1010
Copy link

reinhart1010 commented Jun 8, 2019

The touch target is misaligned.

Screenshot 1

Screenshot 2

I believe neither mozilla-mobile/fenix#2154 and mozilla-mobile/fenix#2563 can clearly describe this issue, so I'm not closing this as duplicate yet.

@reinhart1010
Copy link

To summarize,

  • When user opens the panel while address bar is shown, panel content is shifted towards while touch target (i.e. <a>, <input>, <button> and interactive elements) does not move to new position
  • Otherwise, the site works normally

The panel has

z-index:100;
top:0;
bottom:0;
right:0;

and shown as a flexbox.

@karlcow
Copy link
Member

karlcow commented Aug 21, 2019

This is working for me now. Fixed.

@karlcow karlcow closed this as completed Aug 21, 2019
@karlcow karlcow modified the milestones: needsdiagnosis, fixed Aug 21, 2019
@lock
Copy link

lock bot commented Aug 28, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. type-css-flexbox
Projects
None yet
Development

No branches or pull requests

4 participants