Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack.github.io - Header image is overly large in Firefox #754

Closed
webcompat-bot opened this issue Mar 3, 2015 · 4 comments
Closed

webpack.github.io - Header image is overly large in Firefox #754

webcompat-bot opened this issue Mar 3, 2015 · 4 comments
Milestone

Comments

@webcompat-bot
Copy link

URL: http://webpack.github.io/docs/what-is-webpack.html
Browser / Version: Firefox 36.0
Operating System: Mac OS X 10.10
Problem type: Looks like the website has a bug.
Site owner: No

Steps to Reproduce

  1. Navigate to: http://webpack.github.io/docs/what-is-webpack.html
  2. Notice very large image and a need to scroll to read the text

Expected Behavior:
Works properly in Chrome

Actual Behavior:
Image is overly large

@karlcow
Copy link
Member

karlcow commented Mar 3, 2015

It looks like a very similar issue than https://bugzilla.mozilla.org/show_bug.cgi?id=1138482
min-width: 0 on a parent element doesn't fix it though.

The parent is flex and the image is "max-width: 100%;"

@dholbert an idea?

@dholbert
Copy link

dholbert commented Mar 3, 2015

Yup, similar to that bug indeed.

The image in question is buried inside of two nested flex containers (both with class="row").

At both levels, the flex item (the ancestor of the img that is a child of a flex container) needs "min-width:0", or else it'll size to its min-content width, which is huge because of the huge image.

So, the rules for ".row .col-md-9" and ".row .col-md-12" both need "min-width:0" added to them. (It's possible all of ".col-md" rules want this treatment, for consistency & in case any of them happen to contain wide-yet-shrinkable content.)

I verified locally (using devtools) that adding this style fixes the issue.

@magsout
Copy link
Member

magsout commented Mar 4, 2015

@dholbert 👍

Just make a PR with your idea and it merged.

Fixed now

@dholbert
Copy link

dholbert commented Mar 4, 2015

Thanks!

@karlcow karlcow added this to the fixed milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants