Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.milliyet.com.tr - Navigation arrow for the slider (chevron) is distorted #76776

Closed
rsssxd opened this issue Jun 10, 2021 · 5 comments
Closed
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important priority-normal severity-minor The site has a cosmetic issue. type-css Generic CSS issues
Milestone

Comments

@rsssxd
Copy link

rsssxd commented Jun 10, 2021

URL: https://m.milliyet.com.tr/

Browser / Version: Mozilla/5.0 (Android 11; Mobile; rv:91.0) Gecko/91.0 Firefox/91.0
Operating System: Android 11
Tested Another Browser: Yes Chrome

Problem type: Design is broken
Description: Öğeler yanlış hizalanmış
Steps to Reproduce:
Items are incorrectly loading and corrupt characters

View the screenshot Screenshot
Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added this to the needstriage milestone Jun 10, 2021
@webcompat-bot webcompat-bot added browser-fixme This requires manual assignment for the browser name priority-important labels Jun 10, 2021
@rsssxd
Copy link
Author

rsssxd commented Jun 10, 2021

Chromium SS
Screenshot_20210610-142939

@softvision-oana-arbuzov softvision-oana-arbuzov added browser-firefox-mobile and removed browser-fixme This requires manual assignment for the browser name labels Jun 14, 2021
@softvision-raul-bucata softvision-raul-bucata changed the title m.milliyet.com.tr - design is broken m.milliyet.com.tr - Navigation arrow for the slider (chevron) is distorted Jun 18, 2021
@softvision-raul-bucata softvision-raul-bucata added severity-minor The site has a cosmetic issue. priority-normal labels Jun 18, 2021
@softvision-raul-bucata
Copy link

@reyis4402
We appreciate your report. I was able to reproduce the issue. The navigation arrow for the slider is distorted:

Screenshot_34

Tested with:
Browser / Version: Firefox Nightly 91.0a1 (2015816947 -🦎91.0a1-20210617153900🦎)/ Chrome Mobile Version 91.0.4472.101
Operating System: Samsung A51 (Android 11) -1080 × 2400 pixels 20:9 aspect ratio (~405 ppi density)

Notes:

  1. Reproducible regardless of the status of ETP
  2. Reproducible on the latest build of Firefox Nightly
  3. Works as expected using Chrome:
    Screenshot_35

Moving this to NeedsDiagnosis for further investigations.

@karlcow karlcow added the engine-gecko The browser uses the Gecko rendering engine label Jul 26, 2021
@wisniewskit
Copy link
Member

To draw the arrows the page is using CSS ::after to create a box with a white border on its right and bottom, and then they are rotating it 45 degrees. They then size it by giving it padding:6px. It's inside a flexbox.

It ends up having a square shape normally, but they also apply white-space:pre to it, which seems to trigger Firefox to make the box taller (presumably based on its font-size). Perhaps Firefox is adding a line box where it should not be doing so, given that the element has content:''? I've filed bz1731120 to find out.

In the meantime this can be fixed by resetting the whitespace rule:

.mobile-main-slider .swiper-button-next::after, .mobile-main-slider .swiper-button-prev::after {
	white-space: normal;
}

@wisniewskit wisniewskit added the type-css Generic CSS issues label Sep 16, 2021
@webcompat-bot
Copy link

@wisniewskit wisniewskit added the action-needssitepatch This web bug needs a GoFaster site patch. label Sep 16, 2021
@wisniewskit
Copy link
Member

A fix for this has landed on Firefox nightly builds, and should be rolled out to all users by Firefox 95. I don't think we'll need to take any extra action.

@wisniewskit wisniewskit removed the action-needssitepatch This web bug needs a GoFaster site patch. label Oct 14, 2021
@wisniewskit wisniewskit modified the milestones: needscontact, fixed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-important priority-normal severity-minor The site has a cosmetic issue. type-css Generic CSS issues
Projects
None yet
Development

No branches or pull requests

6 participants