Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news.yahoo.co.jp - Video doesn't play #82605

Open
webcompat-bot opened this issue Aug 7, 2021 · 17 comments
Open

news.yahoo.co.jp - Video doesn't play #82605

webcompat-bot opened this issue Aug 7, 2021 · 17 comments
Labels
browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. sitepatch-applied There is an UA override/intervention in place for this site type-geolocation Issues where a VPN connection was used type-media audio and video issues type-uaoverride Require a UA override for working
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Aug 7, 2021

URL: https://news.yahoo.co.jp/articles/841aaa7adca87e4c7b180917ff8da868d227d924

Browser / Version: Firefox Mobile 91.0
Operating System: Android 11
Tested Another Browser: Yes Chrome

Problem type: Site is not usable
Description: Browser unsupported
Steps to Reproduce:
The videos provided by Yahoo! JAPAN don't play in browsers running on Fenix or Linux browsers.

View the screenshot Screenshot
Browser Configuration
  • gfx.webrender.all: false
  • gfx.webrender.blob-images: true
  • gfx.webrender.enabled: false
  • image.mem.shared: true
  • buildID: 20210802134352
  • channel: beta
  • hasTouchScreen: true
  • mixed active content blocked: false
  • mixed passive content blocked: false
  • tracking content blocked: false

View console log messages

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Aug 7, 2021
@webcompat-bot webcompat-bot added this to the needstriage milestone Aug 7, 2021
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Aug 7, 2021
@webcompat-bot webcompat-bot changed the title In the moderation queue. news.yahoo.co.jp - site is not usable Aug 9, 2021
@webcompat-bot webcompat-bot added browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical and removed browser-fixme This requires manual assignment for the browser name action-needsmoderation The moderation has not yet been completed labels Aug 9, 2021
@softvision-oana-arbuzov softvision-oana-arbuzov added the severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. label Aug 9, 2021
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title news.yahoo.co.jp - site is not usable news.yahoo.co.jp - Videos doesn Aug 9, 2021
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title news.yahoo.co.jp - Videos doesn news.yahoo.co.jp - Videos doesn't play Aug 9, 2021
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title news.yahoo.co.jp - Videos doesn't play news.yahoo.co.jp - Video doesn't play Aug 9, 2021
@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented Aug 9, 2021

Thanks for the report, I was able to reproduce the issue.
image

Note:

  1. The issues it not reproducible on Chrome.
  2. The issue is reproducible on Firefox Nightly regardless of the ETP status.

Console:
image

Tested with:
Browser / Version: Firefox Nightly 92.0a1 (🦎 92.0a1-20210808090543), Firefox Beta 91.0.0-beta.6 (🦎 91.0-20210802134352)
Operating System: Google Pixel 5 (Android 11) - 1080 x 2340 pixels, 19.5:9 ratio (~432 ppi density), Samsung Galaxy S8 (Android 9) - 1440 x 2960 pixels, 18.5:9 ratio (~570 ppi density)
VPN pointing to Japan

Moving to Needsdiagnosis for further investigation.

@karlcow
Copy link
Member

karlcow commented Aug 10, 2021

This is done through user agent sniffing.
The issue can be reproduced in Firefox desktop with rdm mode and Firefox Android UA.
If I switch the UA to be chrome in on RDM, I get the video working.

This is what Chrome is displaying:

<iframe
  id="yvpubplayer0"
  name="frame_yvpubplayer0_1628577914"
  src="//s.yimg.jp/images/yvpub/player/vamos/sd/latest/player.html?contentid=4995710&amp;height=223&amp;width=395&amp;propertyname=jp_news&amp;recommend=0&amp;spaceid=2079842558&amp;autostart=0&amp;repeat=0&amp;quality=240&amp;ds=88946_529603&amp;id=yvpubplayer0&amp;domain=news.yahoo.co.jp&amp;parenturl=https%3A%2F%2Fnews.yahoo.co.jp%2Farticles%2Ff114c5451c4a8f18e4aeccaae8f57a1daaf597fa&amp;parentfullurl=https%3A%2F%2Fnews.yahoo.co.jp%2Farticles%2Ff114c5451c4a8f18e4aeccaae8f57a1daaf597fa&amp;_playersession=ed878271-7756-4f29-88a6-f9601e869458"
  title="Yahoo!ビデオパブリッシャー"
  scrolling="no"
  style="display: block"
  marginheight="0"
  marginwidth="0"
  allowfullscreen="true"
  allow="autoplay; fullscreen"
  data-yvpubviewablecheck="id0"
  data-yvpubintersectionratio="1"
  width="395"
  height="222.1875"
  frameborder="0"
></iframe>

They use videoJS inside the iframe.

The iframe is not triggered on Firefox Android and the error message is being displayed instead.

<script src="https://s.yimg.jp/images/yvpub/player/js/player.js?v=1628578065673"></script>
<div
  class="yvpub-player yjads_priority_3"
  data-contentid="4995710"
  data-height="224"
  data-width="398"
  data-propertyname="jp_news"
  data-recommend="0"
  data-spaceid="2079842558"
  data-autostart="0"
  data-repeat="0"
  data-quality="240"
  data-ds="88946_529603"
  style="
    position: absolute;
    top: 0px;
    left: 0px;
    width: 398px;
    height: 224px;
    vertical-align: middle;
    text-align: center;
    background-color: rgb(0, 0, 0);
    overflow: hidden;
  "
  data-composed="1"
>
  <div
    id="yvpubplayer0"
    data-key="yvpubplayer0"
    style="
      width: 398px;
      height: 224px;
      text-align: center;
      position: relative;
      z-index: 1;
      margin: auto;
      overflow: hidden;
      vertical-align: middle;
      cursor: pointer;
    "
  >
    <div
      style="
        font-size: 14px;
        z-index: 3;
        color: rgb(255, 255, 255);
        position: relative;
        top: 82.5px;
      "
    >
      <span style="font-size: 10px">エラーコード:1001100</span>
      <div>
        ご利用の環境では映像を視聴できません。<br />映像視聴における推奨環境はこちらをご確認ください。
      </div>
    </div>
  </div>
</div>

Let's look at

https://s.yimg.jp/images/yvpub/player/js/player.js?v=1628578063801

Ah hard to debug because they create a parameter based on Epoch time in milliseconds at each new request:

https://s.yimg.jp/images/yvpub/player/js/player.js?v=1628578616434
https://s.yimg.jp/images/yvpub/player/js/player.js?v=1628578698956

There is a function UnsupportedEnvironment

      UnsupportedEnvironment: function () {
        var e = a.isSmartDevice() ? o.commonConfig.HELP_URL.SD : o.commonConfig.HELP_URL.PC,
        n = t && t.noLink ? 'こちら' : '<a href="' + e + '" class="vjs-error-help-link" target="_blank">こちら</a>';
        return new u.default({
          code: 1001100,
          headline: 'ご利用の環境では映像を視聴できません。',
          message: '映像視聴における推奨環境は' + n + 'をご確認ください。',
          options: t
        })
      }()

@karlcow
Copy link
Member

karlcow commented Aug 10, 2021

but it is quite simple. Their support matrix is just not considering Firefox Android.

  W = {
    PC: {
      Windows: {
        VERSION: 7,
        BROWSER_LIST: [
          {
            NAME: 'Chrome',
            VERSION: 31
          },
          {
            NAME: 'Firefox',
            VERSION: 45
          },
          {
            NAME: 'Edge',
            VERSION: z = 'ANY'
          },
          {
            NAME: U = 'ChromiumEdge',
            VERSION: z
          },
          {
            NAME: 'IE',
            VERSION: 11
          }
        ]
      },
      'Mac OS': {
        VERSION: z,
        BROWSER_LIST: [
          {
            NAME: 'Chrome',
            VERSION: 31
          },
          {
            NAME: 'Firefox',
            VERSION: 45
          },
          {
            NAME: U,
            VERSION: z
          },
          {
            NAME: 'Safari',
            VERSION: 8
          }
        ]
      }
    },
    SD: {
      iOS: {
        VERSION: 10,
        BROWSER_LIST: z
      },
      Android: {
        VERSION: 4.4,
        BROWSER_LIST: [
          {
            NAME: 'Chrome',
            VERSION: 53
          },
          {
            NAME: U,
            VERSION: z
          },
          {
            NAME: 'Silk',
            VERSION: z
          },
          {
            NAME: 'Samsung Browser',
            VERSION: z
          },
          {
            NAME: 'Facebook',
            VERSION: z
          },
          {
            NAME: 'Line',
            VERSION: z
          },
          {
            NAME: 'Instagram',
            VERSION: z
          }
        ]
      }
    }
  },

Let's add it to ua override.

@karlcow karlcow added action-needssitepatch This web bug needs a GoFaster site patch. type-uaoverride Require a UA override for working type-media audio and video issues labels Aug 10, 2021
@karlcow
Copy link
Member

karlcow commented Aug 10, 2021

Site Interventions request at https://bugzilla.mozilla.org/show_bug.cgi?id=1724868

@ksy36 ksy36 modified the milestones: needsdiagnosis, needscontact Aug 10, 2021
@webcompat-bot
Copy link
Author

@karlcow karlcow removed their assignment Aug 17, 2021
@ksy36 ksy36 removed the action-needssitepatch This web bug needs a GoFaster site patch. label Sep 1, 2021
@ksy36 ksy36 added the sitepatch-applied There is an UA override/intervention in place for this site label Sep 1, 2021
@ghost
Copy link

ghost commented Oct 13, 2021

The current sitepatch only applies to Yahoo(jp) News, but this Firefox-eliminating video player is also used by at least the following sites.

  • https://movies.yahoo.co.jp/
  • https://soccer.yahoo.co.jp/ws/ (android only)
  • https://sports.yahoo.co.jp/
  • https://tv.yahoo.co.jp
  • https://weather.yahoo.co.jp/weather/video/

@softvision-oana-arbuzov
Copy link
Member

@ksy36
Copy link
Contributor

ksy36 commented Nov 16, 2021

Thanks @hokonch.

Lets try @yahoojapan. Maybe @kpango could help us with this issue. Hi Yusuke, we're wondering what could be a reason for not supporting Firefox on mobile here. Would you be able to pass this along to the relevant person or team to be looked at? Thank you!

@softvision-raul-bucata
Copy link

@karlcow
Copy link
Member

karlcow commented Feb 21, 2022

@myakura do you still have contact with Yahoo! Japan?

@myakura
Copy link

myakura commented Feb 24, 2022

Hey @karlcow,

@myakura do you still have contact with Yahoo! Japan?

I don't know. But I can ask :)

So far, If I'm reading it right, the current situation is:

  1. videos on various yahoo.co.jp domains are unavailable in Firefox for Android
  2. it seems the player (or the page) checks for the UA string and the code does not include FxA (while it does for Desktop)
  3. videos work fine on FxA by switching to the Chrome UA string (meaning the player technically works on FxA)
  4. right now Firefox reports Chrome-like UA string by using its site intervention mechanism to make the videos work
  5. that's not ideal and Mozilla wants to get rid of it

Let me know if there's anything wrong in the points I made, or any other things you want to tell.

@ksy36
Copy link
Contributor

ksy36 commented Feb 25, 2022

Let me know if there's anything wrong in the points I made, or any other things you want to tell.

Not @karlcow, but yes, your points are correct @myakura :)

One thing I wanted to add is, right now we only have Chrome UA intervention only for https://news.yahoo.co.jp/, but as @hokonch mentioned the issue is affecting a lot more subdomains. While we could ship this intervention for all subdomains (essentially *.yahoo.co.jp), that would be less than ideal as it can cause other issues that we are not aware of and Firefox will disappear from Yahoo japan browser usage statistics (if they have any).

@myakura
Copy link

myakura commented Mar 1, 2022

Hello @ksy36 ,

Not @karlcow, but yes, your points are correct @myakura :)

Yay ;)

One thing I wanted to add is, right now we only have Chrome UA intervention only for https://news.yahoo.co.jp/, but as @hokonch mentioned the issue is affecting a lot more subdomains.

Ah. Okay.

While we could ship this intervention for all subdomains (essentially *.yahoo.co.jp), that would be less than ideal as it can cause other issues that we are not aware of and Firefox will disappear from Yahoo japan browser usage statistics (if they have any).

Agreed.

I just sent them a message (pointing to this thread and bugzilla entry). Hopefully getting back soon.

@narirou
Copy link

narirou commented Mar 1, 2022

Hi, all. I'm an engineer at Yahoo! JAPAN.
Thank you for raising this issue.

The player you mentioned is a web player used in all of Yahoo! Japan's services.

It seems that this player judges which browsers can play based on UA, and treats all others as errors.
I will contact the engineer who is creating the player about this issue.

@ksy36
Copy link
Contributor

ksy36 commented Mar 1, 2022

Great, thanks a lot @myakura and @narirou :)

@softvision-raul-bucata
Copy link

Updated link: https://news.yahoo.co.jp/pickup/6423826

@softvision-raul-bucata softvision-raul-bucata added the type-geolocation Issues where a VPN connection was used label Oct 4, 2022
@softvision-raul-bucata
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-fenix engine-gecko The browser uses the Gecko rendering engine priority-critical severity-critical The site or core functionality is unusable, or you would probably open another browser to use it. sitepatch-applied There is an UA override/intervention in place for this site type-geolocation Issues where a VPN connection was used type-media audio and video issues type-uaoverride Require a UA override for working
Projects
None yet
Development

No branches or pull requests

7 participants