Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.wetteronline.de - Desktop page instead of mobile on "Feedback" page #8581

Closed
softvision-oana-arbuzov opened this issue Jul 31, 2017 · 3 comments

Comments

@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented Jul 31, 2017

URL: https://www.wetteronline.de/kontakt

Browser / Version: Firefox Mobile Nightly 56.0a1 (2017-07-31)
Operating System: LG G5 (Android 7.0) - Resolution 1440 x 2560 pixels (~554 ppi pixel density)
Tested Another Browser: Yes

Problem type: Desktop site instead of mobile site
Description: Desktop page instead of mobile on "Feedback" page

Steps to Reproduce:

  1. Navigate to: https://www.wetteronline.de/kontakt.
  2. Observe page layout.

Expected Behavior:
Mobile page is displayed.

Actual Behavior:
Partial desktop page is displayed (page can be scrolled left/right).

Note:

  1. Also reproducible when navigating to https://www.wetteronline.de/uploader page and https://www.wetteronline.de/mitgliedschaft page.
  2. Reproducible on Firefox 54.0 Release (Mobile).
  3. Not reproducible on Chrome (Mobile) 59.0.3071.125.
  4. Screenshot attached.

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv; country: de

Screenshot Description

uploadpagedesktop

dekstoppageaccountchoose

From webcompat.com with ❤️

@softvision-oana-arbuzov softvision-oana-arbuzov changed the title www.wetteronline.de - desktop site instead of mobile site www.wetteronline.de - Desktop page instead of mobile on "Feedback" page Jul 31, 2017
@adamopenweb
Copy link
Collaborator

Thanks for the report @softvision-oana-arbuzov. It appears we are getting the same content as Chrome, spoofing the user agent doesn't fix our problem here.

I believe the difference is how Chrome is handling the viewport tag. Let's ping @karlcow for this.

<meta name="viewport" content="width=device-width">

If we change that to:

<meta name="viewport" content="width=device-width, initial-scale=0.6">

It looks more like Chrome in Firefox. It may make more sense to make the site more responsive. Let's see what Karl has to say.

Firefox w/updated viewport:
screen shot 2017-07-31 at 12 10 32 pm

@karlcow
Copy link
Member

karlcow commented Aug 1, 2017

https://bugzilla.mozilla.org/show_bug.cgi?id=1123938
Firefox Android doesn't have the notion of visual viewport like Chrome does.
Here a lot of the sizes are set with fixed size in pixels.

html/body are set to the width of the viewport

#contentcontainer, #leftcontainer, #totalcontainer, body, html {
	height: 100%;
	-webkit-text-size-adjust: none;
	font-size: 100%;
	min-height: 673px;
	width: 100%;
}

so for example for me, it will be 360px.

but .totalcontainer is set to 675 px and subsequent elements have also a fixed size.

#contentcontainer, #leftcontainer, #totalcontainer {
	max-width: 675px !important;
	min-width: 675px;
}

Duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1123938

@karlcow
Copy link
Member

karlcow commented Jan 24, 2018

Just a note for webcompat historians and archivists, the site has been fixed.

Screenshot Description

Let's see how:

<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
html {
	font-size: 100%;
	width: 100%;
	height: 100%;
	overflow-x: hidden;
	-webkit-text-size-adjust: 100%;
}

body {
	margin: 0;
	-webkit-backface-visibility: hidden;
	min-width: 320px;
	max-width: 700px;
	width: 100%;
	min-height: 100%;
	display: -webkit-box;
	display: -webkit-flex;
	display: -ms-flexbox;
	display: flex;
	-webkit-box-orient: vertical;
	-webkit-box-direction: normal;
	-webkit-flex-direction: column;
	-ms-flex-direction: column;
	flex-direction: column;
	overflow-x: hidden;
	-webkit-tap-highlight-color: transparent;
	background: #fff;
	color: #3c3c3c;
}

#totalcontainer has disappeared. There is a main element.

main {
	width: 100%;
	-webkit-box-flex: 1;
	-webkit-flex: 1;
	-ms-flex: 1;
	flex: 1;
	margin-top: 60px;
}

I will change the status from duplicate to worksforme as we did not contact them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants