New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video.vice.com - Unable to use the Video player controls #8582
Comments
Interesting, I can't reproduce or even play the video on Firefox 56 desktop in responsive design with HLS error message:
But I can reproduce this issue using Firefox 56 mobile. The video element is embedded in an iFrame: <iframe class="watch-hub__embed" src="/de/embed/56b4e8162f91349469c7df00?autoplay=1&channelName=i-d&channelUrl=i-d.vice.com&locked=0&nextVideoId=5968b0f2e3178093226000b8&showInfo=0&watchHub=1" allowfullscreen=""></iframe> Move to needsdiagnosis. |
ok maybe something related with what's coming before the video, which is a video ad. |
Looks like something got broken here. Console says: Script 'https://web-scripts.vice.com/v1.0.4/ads.js' failed to load in 2000 script-loader.ts:18:14 This is the affected part: <iframe class="watch-hub__embed" src="/de/embed/56b4e8162f91349469c7df00?debug=&autoplay=1&onsite=1&continuous=1&adobedebug=0" allowfullscreen=""></iframe> |
This one took some sleuthing, but it's ultimately just an outdated UA sniff (Firefox for Android now supports HLS) in their player-vendors.js script:
When I drop the |
@wisniewskit thanks for the breakdown, the video does play with a Chrome UA spoof. I found there are no controls to exit full screen mode in Firefox. In Chrome there are controls visible to pause / exit full screen, but it doesn't work either. Also the player-vendors.js script appears to be JWPlayer. I wonder if this script is just an outdated version, or if the library should be updated. |
|
Since HLS is not working in release fennec right now, let's figure out when that will happen before contacting anyone. Edit: It's being released in Firefox 59. Scheduled for 3/13/2018, asking around internally as we may have JW Player contacts already. |
@adamopenweb Hey, JW person here. Not quite sure what's going on but we do not officially support Firefox mobile. So it looks like there's two issues here: controls don't work, and FF android doesn't play hls content. The first issue is tricky and I'm not sure what's happening there, but I'd be happy to take a look. The second fix is straigtforward and would just require us to ungate FF+Android for Hls playback. We use a hybrid feature detection/UA parsing approach so it would require a small change from us. Even though we don't officially support it I think it'd make sense for us to fix it anyway. |
Hi @johnBartos thanks for your response! In this comment Firefox is excluded due to not having HLS support. The current Firefox for Android release version is 58, when version 59 launches next week it will support HLS video. You can test this out now by using Firefox Nightly for Android. In our testing HLS videos with JWPlayer have been working as expected in Firefox Nightly, if we change our user agent string to the same as Chrome. It would be great if JW could change the user agent detection, so Firefox users can consume this content as well. |
@adamopenweb I agree. Let me bring this up with the rest of the team before I promise anything, but I think is a sensible change to make |
@adamopenweb Just to be clear, does Firefox 59 support MSE or does it play back HLS natively? And can you provide me any docs which outline this support? Couldn't find anything through google. |
@johnBartos cpearce here, I'm a software engineer on the Firefox Media Playback team. We support HLS in Firefox 59 via the content types "application/vnd.apple.mpegurl", "application/x-mpegurl", "audio/mpegurl", and "audio/x-mpegurl". The best way to check whether Firefox supports HLS is to ask the browser by calling HTMLMediaElement.canPlayType() with one of those MIME types. We support HLS on Android API version > 16, so if you want to sniff server side you could use that, but I recommend you just call canPlayType() client side if possible. Our HLS implementation is "native" and fully integrated and with out media playback stack, so you can just set a url to an m3u8 resource in HTMLMediaElement.src and it should just work. Firefox on Android has supported MSE for a while now. |
Oops! Thanks for the correction. I'm afraid I may have potentially misdiagnosed the issue; I'll come back with an update when I've studied the code and done some tests myself. |
@adamopenweb Ok I did some digging. Vice is using an old version of the Player (8.0.0-beta.3) which gated Hls.js playback (via MSE) if a specific flag was not set ( We have since made Hlsjs default for Android, and I have confirmed that playback works as expected in the latest version (8.1.12). I have poked some people internally and hopefully our Vice account manager will get them to upgrade soon. I assume the frozen controls bug is related to this (the controls may show while the player is working out this error, but won't do anything). But if a video plays and the controls are not working please make an issue in our repo. |
OK so the video is playing as expected now in Firefox Android 59+ 🎉 There are still two issues:
Filed jwplayer/jwplayer#2829 for the controls issue. |
I've closed jwplayer/jwplayer#2829 The video controls on vice.com are not the controls provided by jwplayer.js ( |
URL: https://video.vice.com/de/video/the-chinese-friends/56b4e8162f91349469c7df00?latest=1
Browser / Version: Firefox Mobile Nightly 56.0a1 (2017-07-30)
Operating System: Samsung Galaxy S7 Edge (Android 7.0) - 1440 x 2560 pixels (~534 ppi pixel density)
Tested Another Browser: Yes
Problem type: Site is not usable
Description: Unable to use the Video player controls
Steps to Reproduce:
Expected Behavior:
The Video controls are displayed.
Actual Behavior:
The Video controls are not displayed.
Notes:
Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
sv; country: de
Screen capture video.zip
From webcompat.com with ❤️
The text was updated successfully, but these errors were encountered: