Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.google.com - The "Dark theme" option of the page is presented broken if the user is signed in #95222

Closed
webcompat-bot opened this issue Dec 1, 2021 · 3 comments
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-css Generic CSS issues
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Dec 1, 2021

URL: https://www.google.com/search?q=metroid+dread&client=firefox-b-1-d&sxsrf=AOaemvJIAy5vVf8RWW4HhClgVx9ml5GjGQ:1638327172467&source=lnms&tbm=shop&sa=X&ved=2ahUKEwiR14-pzMH0AhVoDjQIHdSUDZ4Q_AUoAXoECAEQAw&biw=1047&bih=598&dpr=2

Browser / Version: Firefox 94.0.2
Operating System: Mac OS X 10.15.7
Tested Another Browser: Yes Chrome

Problem type: Something else
Description: When Google search is set to Dark Mode, the Google Shopping page doesn't display correctly
Steps to Reproduce:
To reproduce this, make sure Google is set to dark mode. In the upper right, click the setting cog and turn Dark Theme on. Next, go to the Google Shopping page. It won't look right if you do this in Firefox. It displays correctly in Chrome and Safari.

View the screenshot Screenshot
Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Dec 1, 2021
@webcompat-bot webcompat-bot added this to the needstriage milestone Dec 1, 2021
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Dec 1, 2021
@webcompat-bot webcompat-bot changed the title In the moderation queue. www.google.com - see bug description Dec 2, 2021
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-critical and removed browser-fixme This requires manual assignment for the browser name action-needsmoderation The moderation has not yet been completed labels Dec 2, 2021
@softvision-raul-bucata softvision-raul-bucata added the os-mac Issues only happening on macOS. label Dec 2, 2021
@softvision-raul-bucata
Copy link

We appreciate your report. I was able to reproduce the issue using other devices as well. Following the link provided, if the settings for "Dark Theme" are enabled from the search settings and the user is logged into the account, the "Dark Theme" option of the page is presented broken:

Screenshot_10

If the user is not signed in, the theme is presented as expected:

Screenshot_11

Tested with:

Browser / Version: Firefox Release 94.0.2 (64-bit)/ Firefox Nightly 96.0a1 (2021-12-01) (64-bit)/Chrome Version 96.0.4664.45 (Official Build) (64-bit)
Operating System: Windows 10 PRO x64
Operating System: Mac OSX 10.15.6

Notes:

  1. Reproducible regardless of the status of ETP.
  2. Reproducible on the latest build of Firefox Nightly.
  3. User is signed in.
  4. Works as expected using Chrome:

Screenshot_9

Moving this to NeedsDiagnosis for further investigations.

@softvision-raul-bucata softvision-raul-bucata changed the title www.google.com - see bug description www.google.com - The "Dark theme" option of the page is presented broken if the user is signed in Dec 2, 2021
@softvision-raul-bucata softvision-raul-bucata added severity-important A non-core broken piece of functionality, not behaving the way you would expect. priority-normal and removed priority-critical labels Dec 2, 2021
@wisniewskit
Copy link
Member

It appears that in Chrome, the background color of that containing element (<div style="float:left;width:100%">, in div#rcnt) is inherited from this CSS right in a style tag in the base document:

body {
    background: #dddee1;
}

Chrome is using that to compute the color for the dark version. Firefox's devtools don't show the background style at all when I inspect that element (but do when I inspect the body tag). If I add the background#dddee1 to the element manually in the inspector, the color shows up as expected.

To me, Firefox is doing the right thing, because background CSS isn't inherited, so I'm not sure why Chrome is doing this (unless it's some sort of quirk of dark mode?)

@karlcow karlcow assigned karlcow and unassigned wisniewskit Mar 11, 2022
@karlcow
Copy link
Member

karlcow commented Mar 30, 2022

https://www.google.com/search?q=metroid+dread&cs=2&source=lnms&tbm=shop&sa=X&ved=2ahUKEwjalOrrsO32AhXE-WEKHdX2BqMQ_AUoA3oECAEQBQ

This is what I get.

Capture d’écran 2022-03-30 à 17 09 23

The way the dark mode is created is with

html {
 filter:invert(1) hue-rotate(180deg)
}

except that this doesn't seem to have the same effect at all in firefox and Blink.

This is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1682083

@karlcow karlcow closed this as completed Mar 30, 2022
@karlcow karlcow removed their assignment Mar 30, 2022
@karlcow karlcow modified the milestones: needsdiagnosis, moved Mar 30, 2022
@karlcow karlcow added the type-css Generic CSS issues label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine os-mac Issues only happening on macOS. priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-css Generic CSS issues
Projects
None yet
Development

No branches or pull requests

4 participants