Test for #980 [not ready to merge] #1432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miketaylr could you test if you can get browserstack test results from this branch? prerequisites are at top, #1432 (comment) |
|
just created a wiki page that summarizes the results of this PR and the BrowserStack status relative to the goals: https://github.com/webcompat/webcompat.com/wiki/BrowserStack-Tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edit 033017: updated the BROWSERSTACK_USER value for the new account)
Issues/980/18
@miketaylr this is similar to an old branch, issues/980/15
requires
npm install(to get a browserstack testing package)server should be running locally
to run tests triggered locally but hitting browserstack servers (just update BROWSERSTACK_KEY value):
(edit 033017) for the BROWSERSTACK_KEY, you need to log into BrowserStack
I can't figure out how to make the tests run off travis. also a heads up that the browserstack account is giving an expiration notice (in 20 days). I've made a contact to their support to get an extension and am also making a request to update the account owner email (away from my personal email). will send those details separately.
let me know if you have any questions.