Adds CSSCustomState to schema #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
commented
Nov 9, 2023
|
Can someone review this PR? |
|
This looks fine to me 👍 Konnor was already working on a PR to add this to @justinfagnani can you also take a look? Seems like a quick win :) |
|
love to see the power of the opensource community at work ! |
justinfagnani
requested changes
Apr 24, 2024
|
@lukewarlow the scheme needs to be regenerated |
|
That's done now sorry |
|
@justinfagnani is there anything else you need me to change? |
justinfagnani
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
See https://wicg.github.io/custom-state-pseudo-class/#exposing for the WICG proposal.
See whatwg/html#8467 for HTML PR and w3c/csswg-drafts#8213 for CSS PR (not a direct match for the WICG proposal)
While this is currently only supported in Chromium (in a form that doesn't match the latest spec) there's an effort to get this cross browser. See https://groups.google.com/a/mozilla.org/g/dev-platform/c/vDVxI6O3YqU for a Firefox I2P.
There's also interest within OpenUI to use this schema for our anatomies which would make use of this too.