Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

ShadyDOM breaks partial table templates #208

Closed
justinfagnani opened this issue Jan 14, 2018 · 1 comment · Fixed by #240
Closed

ShadyDOM breaks partial table templates #208

justinfagnani opened this issue Jan 14, 2018 · 1 comment · Fixed by #240

Comments

@justinfagnani
Copy link

Description

When ShadyDOM is enabled, partial table templates like:

const template = document.createElement('template');
template.innerHTML = '<tr></tr>';

don't have any children.

Live Demo

https://codepen.io/justinfagnani/pen/ypEdQo?editors=1111

Steps to Reproduce

  1. Create a template
  2. Set its innerHTML to ""
  3. Read its innerHTML, it's now blank

Browsers Affected

All

Versions

  • shadydom: 1.0.11
@TimvdLippe
Copy link
Contributor

After webcomponents/template#39 has been merged, we have to reinvestigate if this has been addressed.

@bgotink bgotink mentioned this issue May 21, 2018
Closed
bgotink added a commit to bgotink/shadydom that referenced this issue May 21, 2018
@bgotink
Use template element in patched innerHTML of template elements
6d51cf1 
Templates support table subelements (e.g. tr, td) as root element in their
innerHTML, divs don't.

Fixes webcomponents#208
Linked to lit/lit#327
@bgotink bgotink mentioned this issue May 21, 2018
Merged
bgotink added a commit to bgotink/shadydom that referenced this issue Jun 2, 2018
@bgotink
Use template element in patched innerHTML of template elements
e07fc25 
Templates support table subelements (e.g. tr, td) as root element in their
innerHTML, divs don't.

Fixes webcomponents#208
Linked to lit/lit#327
@sorvell sorvell mentioned this issue Jun 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use template element in patched innerHTML of template elements bgotink/shadydom
2 participants
@justinfagnani @TimvdLippe