This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
Replace broken 'gulp debug' with 'npm run debug' #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incorporated some changes as requested in webcomponents/custom-elements#164 |
TimvdLippe
approved these changes
Aug 15, 2018
There was a problem hiding this comment.
LGTM! @ruphin could you rebase this to fix the merge conflicts? Then we can merge 😄
ruphin
force-pushed
the
fix_debug_build
branch
from
6d9f673
to
85f3116
Compare
ruphin
force-pushed
the
fix_debug_build
branch
from
85f3116
to
12ed737
Compare
|
Hm, I never got a GitHub e-mail about the rebase. Anyhow, merging thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gulp debugbuild command was broken and did not produce any output. I replaced it with a functionally identicalnpm run debugcommand that invokes Rollup directly to produce the same output.