Merge branch 'release-0.6.0'

webdevel · Nov 4, 2017 · 18b4364 · 18b4364
2 parents 4bf0a9b + f85ddfb
commit 18b4364
Show file tree

Hide file tree

Showing 9 changed files with 29 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Release Notes
 
+## 0.6.0
+- modify webpack config to add source maps support
+- modify readme to include downloads and dependencies badges
+- modify code to use better comparison for undefined
+- modify `package.json` to update dependencies
+
 ## 0.5.0
 - modify document readme to add version and license badges
 

diff --git a/README.md b/README.md
@@ -1,8 +1,10 @@
 # Youtube Search Google API
 [![Build Status](https://travis-ci.org/webdevel/youtube-search-google-api.svg?branch=master)](https://travis-ci.org/webdevel/youtube-search-google-api)
 [![Coverage Status](https://coveralls.io/repos/github/webdevel/youtube-search-google-api/badge.svg?branch=master)](https://coveralls.io/github/webdevel/youtube-search-google-api?branch=master)
-[![Version](https://img.shields.io/npm/v/youtube-search-google-api.svg?)](https://www.npmjs.com/package/youtube-search-google-api)
+[![Version](https://img.shields.io/npm/v/youtube-search-google-api.svg)](https://www.npmjs.com/package/youtube-search-google-api)
 [![License](http://img.shields.io/badge/license-MIT-blue.svg?)](LICENSE)
+[![Downloads](https://img.shields.io/npm/dt/youtube-search-google-api.svg)](https://www.npmjs.org/package/youtube-search-google-api)
+[![Dependencies](https://img.shields.io/david/webdevel/youtube-search-google-api.svg)](https://david-dm.org/webdevel/youtube-search-google-api)
 
 YouTube Search Google API for [Node.js]. Search for YouTube videos, channels, playlists and live events via Google API for [Node.js].
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "youtube-search-google-api",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "YouTube Search Google API for Node.js. Search for YouTube videos, channels, playlists and live events via Google API for Node.js.",
   "main": "dist/youtube-search.js",
   "module": "lib/entry.js",
@@ -35,9 +35,9 @@
     "esdoc-standard-plugin": "^1.0.0",
     "mocha": "^4.0.1",
     "ncp": "^2.0.0",
-    "nyc": "^11.2.1",
+    "nyc": "^11.3.0",
     "rimraf": "^2.6.2",
-    "sinon": "^4.0.1",
+    "sinon": "^4.1.1",
     "sinon-chai": "^2.14.0",
     "uglifyjs-webpack-plugin": "^1.0.1",
     "webpack": "^3.8.1"
@@ -82,7 +82,7 @@
     "doc": "rimraf docs/* && esdoc",
     "test": "cross-env NODE_ENV=test nyc --reporter=text mocha --require babel-register --timeout 9000",
     "coverage": "nyc report --reporter=text-lcov | coveralls",
-    "webpack": "rimraf dist/* && webpack --env.production --env.NODE_ENV=production",
+    "webpack": "rimraf dist/* && webpack --env.production --env.NODE_ENV=production --define process.env.NODE_ENV=\"'production'\"",
     "webpack:dev": "webpack --env.development --env.NODE_ENV=development"
   },
   "contributors": [

diff --git a/src/DefaultClient.js b/src/DefaultClient.js
@@ -10,7 +10,7 @@ export default class DefaultClient extends Client {
    * @return {Handler} Handles requests
    */
   get handler() {
-    if (typeof this._handler === 'undefined') {
+    if (undefined === this._handler) {
       this._handler = new XHRHandler()
     }
     return this._handler

diff --git a/src/HTTPHandler.js b/src/HTTPHandler.js
@@ -26,7 +26,7 @@ export default class HTTPHandler extends Handler {
    * @return {function} HTTP client
    */
   get client() {
-    if (typeof this._client === 'undefined') {
+    if (undefined === this._client) {
       this._client = require('request')
     }
     return this._client

diff --git a/src/SearchRequest.js b/src/SearchRequest.js
@@ -13,7 +13,7 @@ export default class SearchRequest extends Request {
    * @return {String} HTTP method: GET, POST...
    */
   get method() {
-    if (typeof this._method === 'undefined') {
+    if (undefined === this._method) {
       this._method = this.specs.method
     }
     return this._method
@@ -30,7 +30,7 @@ export default class SearchRequest extends Request {
    * @return {String} URL
    */
   get url() {
-    if (typeof this._url === 'undefined') {
+    if (undefined === this._url) {
       this._url = `${this.specs.uri}${this.query}`
     }
     return this._url
@@ -67,7 +67,7 @@ export default class SearchRequest extends Request {
       const key = keys[index]
       let param = find(params, { 'name': key })
 
-      if (typeof param === 'undefined') {
+      if (undefined === param) {
         result = false
         throw new Error('Invalid query parameter name specified: ' + key)
 
@@ -87,7 +87,7 @@ export default class SearchRequest extends Request {
         } else if (typeof param.values[0] !== 'string' && typeof param.values[0] !== 'number') {
 
           let value = find(param.values, { 'value': query[key]})
-          if (typeof value === 'undefined') {
+          if (undefined === value) {
             result = false
             throw new Error(`Invalid query parameter value for ${key} specified: ${query[key]}`)
           }
@@ -118,7 +118,7 @@ export default class SearchRequest extends Request {
    * @return {Object} Container of query parameters
    */
   get queryParameters() {
-    if (typeof this._queryParameters === 'undefined') {
+    if (undefined === this._queryParameters) {
       this._queryParameters = {
         part: 'snippet'
       }
@@ -140,7 +140,7 @@ export default class SearchRequest extends Request {
    * @return {Object} YouTube Search API specification
    */
   get specs() {
-    if (typeof this._specs === 'undefined') {
+    if (undefined === this._specs) {
       this._specs = searchSpec
     }
     return this._specs

diff --git a/src/XHRHandler.js b/src/XHRHandler.js
@@ -31,7 +31,7 @@ export default class XHRHandler extends Handler {
    * @return {function} XHR client
    */
   get client() {
-    if (typeof this._client === 'undefined') {
+    if (undefined === this._client) {
       this._client = require('xhr')
     }
     return this._client
@@ -48,7 +48,7 @@ export default class XHRHandler extends Handler {
    * @return {Handler} Successor to delegate request if desired
    */
   get successor() {
-    if (typeof this._successor === 'undefined') {
+    if (undefined === this._successor) {
       this._successor = new HTTPHandler()
     }
     return this._successor

diff --git a/src/YouTube.js b/src/YouTube.js
@@ -18,7 +18,7 @@ export default class YouTube {
    * @return {Client} Client to invoke requests
    */
   get client() {
-    if (typeof this._client === 'undefined') {
+    if (undefined === this._client) {
       this._client = new DefaultClient()
     }
     return this._client

diff --git a/webpack.config.js b/webpack.config.js
@@ -5,10 +5,13 @@ const targetDir = path.resolve(__dirname, 'dist')
 
 module.exports = env => {
 
+  // initialize for development environment
   let filename = '[name].js', plugins = []
+  let sourceMap = 'inline-source-map'
 
   if (env.production) {
 
+    sourceMap = 'source-map'
     filename = '[name].min.js'
     plugins.push(
       new UglifyJSPlugin({
@@ -48,6 +51,7 @@ module.exports = env => {
         }
       ]
     },
-    plugins: plugins
+    plugins: plugins,
+    devtool: sourceMap
   }
 }