Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blackfire env vars #113

Closed
choonge opened this issue Jun 29, 2016 · 2 comments
Closed

Add Blackfire env vars #113

choonge opened this issue Jun 29, 2016 · 2 comments
Labels
enhancement image: webdevops/php*dev PR/patch available

Comments

@choonge
Copy link
Contributor

choonge commented Jun 29, 2016

Blackfire needs an id and token to be written to its .ini file. It looks quite similar to #90 . Would be nice to implement both of these in the same manner. Any idea how #90 will be built? Read an env var and have an entrypoint.d script write it to the .ini?
@mblaschke
Copy link
Member

BLACKFIRE_TOKEN?
BLACKFIRE_ID?

@choonge
Copy link
Contributor Author

choonge commented Jun 30, 2016

I would match the php.ini variable naming as closely as possible, so BLACKFIRE_SERVER_ID and BLACKFIRE_TOKEN. But, do you agree that having an entrypoint.d script set this, is the correct way? Or is there a better place to do this, in the big picture of the project?

mblaschke added a commit that referenced this issue Jun 30, 2016
@mblaschke
✨ 📚 Add xdebug and blackfire environment variables
68e56bc 
Add following environment variables
- XDEBUG_REMOTE_CONNECT_BACK
- XDEBUG_REMOTE_AUTOSTART
- XDEBUG_REMOTE_HOST
- XDEBUG_REMOTE_PORT
- BLACKFIRE_SERVER_ID
- BLACKFIRE_SERVER_TOKEN
Fixes #113
Fixes #90
@mblaschke mblaschke mentioned this issue Jun 30, 2016
Merged
mblaschke added a commit that referenced this issue Jun 30, 2016
@mblaschke
✨ 📚 Add xdebug and blackfire environment variables
ca75a84 
Add following environment variables
- XDEBUG_REMOTE_CONNECT_BACK
- XDEBUG_REMOTE_AUTOSTART
- XDEBUG_REMOTE_HOST
- XDEBUG_REMOTE_PORT
- BLACKFIRE_SERVER_ID
- BLACKFIRE_SERVER_TOKEN
Fixes #113
Fixes #90
mblaschke added a commit that referenced this issue Jun 30, 2016
@mblaschke
✨ 📚 Add xdebug and blackfire environment variables
96f262e 
Add following environment variables
- XDEBUG_REMOTE_CONNECT_BACK
- XDEBUG_REMOTE_AUTOSTART
- XDEBUG_REMOTE_HOST
- XDEBUG_REMOTE_PORT
- BLACKFIRE_SERVER_ID
- BLACKFIRE_SERVER_TOKEN
Fixes #113
Fixes #90
guiyomh pushed a commit that referenced this issue Jul 1, 2016
@mblaschke @guiyomh
✨ 📚 Add xdebug and blackfire environment variables (#115)
b9ed636 
* ✨ 📚 Add xdebug and blackfire environment variables

Add following environment variables
- XDEBUG_REMOTE_CONNECT_BACK
- XDEBUG_REMOTE_AUTOSTART
- XDEBUG_REMOTE_HOST
- XDEBUG_REMOTE_PORT
- BLACKFIRE_SERVER_ID
- BLACKFIRE_SERVER_TOKEN
Fixes #113
Fixes #90

* ✨ Add blackfire-agent

Install package and configure service to run blackfire-agent on same host

Fixes #116
This was referenced Jul 1, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement image: webdevops/php*dev PR/patch available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@choonge @mblaschke