Skip to content
This repository has been archived by the owner on Aug 8, 2022. It is now read-only.

Caching of __CURRENT__ in GeneralUtility::$rootlineCache breaks Sitemap...Tasks #533

Open
stuartmcfarlane opened this issue Dec 17, 2018 · 1 comment

Comments

@stuartmcfarlane
Copy link

Multi site installations will only build the sitemap.xml of the first site.

The AbstractSitemapTask iterates over the root pages calling AbstractTask::initRootPage for each root page and subsequently buildSitemap. buildSitemap will then instantiate a Generator whose constructor will call GeneralUtility::getRootPid to get the root pid that was set when AbstractTask::initRootPage was called. This only works in the first iteration because GeneralUtility::getRootLine will be called in each iteration without specifying the uid meaning the cached CURRENT rootline will always be used regardless of the actual current pid.

MetaSEO version: 2.1.0

TYPO3 version: 7.6.29

PHP version: 5.5.38

@thomaszbz
Copy link
Member

@stuartmcfarlane Thanks for catching this and thanks for the patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants