Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdoor dual outlet module only shows outlet A in Home Assistant #40

Closed
bwarden opened this issue Jul 22, 2019 · 3 comments
Closed

Outdoor dual outlet module only shows outlet A in Home Assistant #40

bwarden opened this issue Jul 22, 2019 · 3 comments

Comments

@bwarden
Copy link

bwarden commented Jul 22, 2019

I think the problem is here:
https://github.com/markperdue/pyvesync/blob/5cf2c8b667aae0dd7b82d93619f277fc6e7c8800/home_assistant/custom_components/switch.py#L51-L54

CID is the same for both subdevices, so we probably need to append the subdevice number so HA sees the outlets as two separate entities.

@bwarden
Copy link
Author

bwarden commented Jul 22, 2019

Sample patch:
https://gist.github.com/bwarden/947fd5932fb97f9af401a435ba08504a

For anybody that uses this, it will create two new switches, leaving an old cached entity with the un-appended CID.

@webdjoe
Copy link
Owner

webdjoe commented Jul 22, 2019

This will be fixed in the next HA release. I stopped developing this custom component because the new config flow only supports in builtin integrations, now you can add and configure vesync through the UI. I have all new devices supported, they just allow only one platform per PR, so this one includes all outlets and switches - home-assistant/core#24953

@bwarden
Copy link
Author

bwarden commented Jul 22, 2019

Nice! I'll watch for the release.

@bwarden bwarden closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants