Added support for LV600s #112

brianhealey · 2022-02-07T20:26:56Z

No description provided.

webdjoe · 2022-02-11T07:29:43Z

src/pyvesync/vesyncfan.py

+        if mode.lower() not in ['sleep', 'auto', 'humidity']:
+            logger.warning('Invalid humidity mode used (sleep, auto, or '
+                           'humidity)- %s',
+                           mode)


Is there a difference between auto and humidity? Are there three modes on all devices? I only see auto and sleep mode on the other humidifiers. May have to put feature logic to adjust mode settings per device.

I haven't actually tried auto. I based this PR off of what I was see in my captures. Agreed on adding the feature logic.

TBH, with all of the devices I am seeing in their app, this pattern is going to be outgrown pretty quick. :)

{ "traceId": "[TRACE_ID]", "payload": { "method": "setHumidityMode", "data": { "mode": "humidity" }, "source": "APP" }, "token": "[TOKEN]", "appVersion": "VeSync 3.2.6 build6", "configModule": "WFON_AHM_LUH-A602S-WUS_US", "method": "bypassV2", "cid": "[CID]", "debugMode": false, "deviceRegion": "US", "phoneBrand": "iPhone 12 Pro", "userCountryCode": "US", "acceptLanguage": "en", "accountID": "[ACCOUNTID]", "timeZone": "America\\/Chicago", "phoneOS": "iOS 15.4" }

auto didn't work for me. I changed my PR to simplify the interface. The caller won't have to know the distinction with this approach.

yeah, I can confirm with my testing that auto seems to have been renamed to humidity for the LV600S.

looking forward to seeing this PR soon.

Will have to make a new class or restructure logic. If you enjoy painful activities, building a test would be a great idea 😉

anoblet · 2022-03-01T17:14:51Z

Any update on this?

webdjoe · 2022-03-01T18:40:22Z

I am in the process of refactoring the library to make it easier to add devices. Should be ready in a day or two.

…

On Tue, Mar 1, 2022 at 12:15 PM Andrew Noblet ***@***.***> wrote: Any update on this? — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6JJBSXX4TWHMANOLUSKNLU5ZGBPANCNFSM5NYPZ7VA> . You are receiving this because you commented.Message ID: ***@***.***>

brianhealey · 2022-03-05T00:47:04Z

Sorry, just getting back to this. Do you want me to provide tests for this, or would you prefer to just wait for the new release?

adityapavan18 · 2022-03-08T17:54:47Z

Any word on when this will be merged and be available in new version?

webdjoe · 2022-03-09T15:20:47Z

I have a branch ready to test, I incorporated all of your changes except the readme file. I will update that in the next day or so when hopefully testing works - https://github.com/webdjoe/pyvesync/tree/air-refactor

anoblet · 2022-03-10T18:09:04Z

I don't see my humidifier listed with this branch.

webdjoe · 2022-03-10T19:07:51Z

Can you add logger.setLevel(logging.DEBUG) after the logging line and tell me what output you get. There should be a message with your device typee

anoblet · 2022-03-10T20:33:26Z

I fairly novice at this. Which file would I put that in?

This is what I'm trying:

pip install git+https://github.com/webdjoe/pyvesync.git@air-refactor

import sys

from pyvesync import VeSync

from pprint import pprint

manager = VeSync("", "", "EST")
manager.login()
manager.update()

devices = manager.get_devices()
pprint(vars(manager));

Only my air purifiers are returned.

webdjoe · 2022-03-11T02:15:50Z

@anoblet I just added a debug feature so when you instantiate the class you can use VeSync('user', 'pass', time_zone='America/New_York', debug=True) this will print out your device dictionary. Please post it here

anoblet · 2022-03-11T10:17:19Z

https://gist.github.com/anoblet/f147e8b764b0d5c668352e889ca028ed

adityapavan18 · 2022-03-16T00:15:33Z

I tried the air-refactor code and it fails for me

manager.update()
2022-03-15 18:12:24,656 - DEBUG - [post] calling '/cloud/v1/deviceManaged/devices' api
2022-03-15 18:12:24,658 - DEBUG - Starting new HTTPS connection (1): smartapi.vesync.com:443
2022-03-15 18:12:25,133 - DEBUG - https://smartapi.vesync.com:443 "POST /cloud/v1/deviceManaged/devices HTTP/1.1" 200 None
2022-03-15 18:12:25,135 - DEBUG - New device list initialized
2022-03-15 18:12:25,135 - DEBUG - LUH-A602S-WUS device not added
2022-03-15 18:12:25,135 - ERROR - Please set modes for LAP-C401S-WUSR in the configuration
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesync.py", line 289, in update
self.get_devices()
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesync.py", line 238, in get_devices
proc_return = self.process_devices(device_list)
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesync.py", line 211, in process_devices
device_str, device_obj = object_factory(dev_type, dev, self)
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesync.py", line 50, in object_factory
type_str, dev_obj = fans(dev_type, config, manager)
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesync.py", line 32, in fans
return 'fans', fan_obj(config, manager)
File "/usr/local/Cellar/python@3.9/3.9.1_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/pyvesync/vesyncfan.py", line 127, in init
raise Exception
Exception

webdjoe · 2022-03-17T22:36:33Z

@brianhealey @adityapavan18 @anoblet Can you give the updated #121 branch a shot. It should be working now

adityapavan18 · 2022-03-17T23:00:23Z

@webdjoe - no errors like before while running manager.update

But when I try to display the details using

for device in manager.fans:
... device.display()

Information doesn't show up properly for Air Purifier

Device Name:... Air Purifier
Model: ........ LAP-C401S-WUSR
Subdevice No: . None
Status: ....... off
Online: ....... online
Type: ......... wifi-air
CID: .......... IREDACTEDTHIS
UUID: ......... IREDACTEDTHIS
Mode: .............. Mode: Mode:
Filter Life: ....... Filter Life: Filter Life:
Fan Level: ......... Fan Level: Fan Level:
Display: ........... Display: Display:
Child Lock: ........ Child Lock: Child Lock:
Night Light: ....... Night Light: Night Light:
Display Config: .... Display Config: Display Config:
Display_Forever Config: Display_Forever Config: Display_Forever Config:
Air Quality: ....... Air Quality: Air Quality:

anoblet · 2022-03-18T01:15:25Z

@webdjoe

Here are my new logs:

https://gist.github.com/anoblet/424a1ad88ba53e93218511246859b03c

webdjoe · 2022-03-20T02:21:52Z

This should be all set, releasing pypi package now. Let me know if there are still any issues

anoblet · 2022-03-23T00:47:26Z

Will this be added to Home Assistant?

webdjoe · 2022-03-24T03:22:37Z

@anoblet you would have to submit a PR to HA repo to update the pyvesync package requirements to 2.0.0 unless you build from scratch

webdjoe · 2022-10-11T07:23:33Z

You would have to submit a PR to HA to change the package version in requirements or build from the source. The latest version is 2.0.0

…

On Tue, Mar 22, 2022 at 8:47 PM Andrew Noblet ***@***.***> wrote: Will this be added to Home Assistant? — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6JJBX3X52ZZ3Y3A4YAWPTVBJS2RANCNFSM5NYPZ7VA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

brianhealey added 2 commits February 7, 2022 14:26

Added support for LV600s

83e3bee

Added support for LV600s

523b2b3

brianhealey mentioned this pull request Feb 7, 2022

Add support for Levoit LV_600S Humidifier #100

Closed

brianhealey added 3 commits February 7, 2022 14:50

Removed unsupported night light feature for LV600s

b98825c

Added support for auto-humidity mode for the LV600S

5a0b6a7

Fixed a linter complaint

fb6a3f4

webdjoe reviewed Feb 11, 2022

View reviewed changes

brianhealey added 2 commits February 13, 2022 15:47

Implement auto humidity mode on lv600s using a simpler method

c3c0dea

Merge branch 'master' into LV600S

09da652

webdjoe closed this Mar 20, 2022

brianhealey deleted the LV600S branch May 27, 2022 17:44

CLARENNE-Q mentioned this pull request Jan 10, 2023

Integrate lv600s formatBCE/HA_VeSync_Classic300s#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for LV600s #112

Added support for LV600s #112

brianhealey commented Feb 7, 2022

webdjoe Feb 11, 2022

brianhealey Feb 13, 2022

brianhealey Feb 13, 2022

alex-w-k Feb 16, 2022

webdjoe Feb 18, 2022

anoblet commented Mar 1, 2022

webdjoe commented Mar 1, 2022 via email

brianhealey commented Mar 5, 2022

adityapavan18 commented Mar 8, 2022

webdjoe commented Mar 9, 2022

anoblet commented Mar 10, 2022

webdjoe commented Mar 10, 2022

anoblet commented Mar 10, 2022 •

edited

webdjoe commented Mar 11, 2022

anoblet commented Mar 11, 2022

adityapavan18 commented Mar 16, 2022

webdjoe commented Mar 17, 2022

adityapavan18 commented Mar 17, 2022

anoblet commented Mar 18, 2022 •

edited

webdjoe commented Mar 20, 2022

anoblet commented Mar 23, 2022

webdjoe commented Mar 24, 2022

webdjoe commented Oct 11, 2022 via email

Added support for LV600s #112

Added support for LV600s #112

Conversation

brianhealey commented Feb 7, 2022

webdjoe Feb 11, 2022

Choose a reason for hiding this comment

brianhealey Feb 13, 2022

Choose a reason for hiding this comment

brianhealey Feb 13, 2022

Choose a reason for hiding this comment

alex-w-k Feb 16, 2022

Choose a reason for hiding this comment

webdjoe Feb 18, 2022

Choose a reason for hiding this comment

anoblet commented Mar 1, 2022

webdjoe commented Mar 1, 2022 via email

brianhealey commented Mar 5, 2022

adityapavan18 commented Mar 8, 2022

webdjoe commented Mar 9, 2022

anoblet commented Mar 10, 2022

webdjoe commented Mar 10, 2022

anoblet commented Mar 10, 2022 • edited

webdjoe commented Mar 11, 2022

anoblet commented Mar 11, 2022

adityapavan18 commented Mar 16, 2022

webdjoe commented Mar 17, 2022

adityapavan18 commented Mar 17, 2022

anoblet commented Mar 18, 2022 • edited

webdjoe commented Mar 20, 2022

anoblet commented Mar 23, 2022

webdjoe commented Mar 24, 2022

webdjoe commented Oct 11, 2022 via email

anoblet commented Mar 10, 2022 •

edited

anoblet commented Mar 18, 2022 •

edited