Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root path should be relative #175

Open
obiot opened this issue Jun 14, 2022 · 2 comments
Open

root path should be relative #175

obiot opened this issue Jun 14, 2022 · 2 comments

Comments

@obiot
Copy link

obiot commented Jun 14, 2022

when specified, the root path is absolute, creating some issue along the way especially when running the doc locally vs deploying it on a website (requiring to change the webdoc config and specify a different root path for both case)
@obiot obiot mentioned this issue Jun 15, 2022
Closed
obiot added a commit to melonjs/melonJS that referenced this issue Jun 15, 2022
@obiot
change root folder for local doc generation
683a3df 
webdoc-labs/webdoc#175
@ShukantPal
Copy link
Member

Do you mean links should be relative and not absolute?

@obiot
Copy link
Author

obiot commented Jun 16, 2022

exactly, it should not be necessary to specify a root folder when generating the documentation, everything should be relative to the base index.html

@ShukantPal ShukantPal modified the milestone: v2.0.0 Jun 26, 2022
obiot added a commit to melonjs/melonJS that referenced this issue Jul 11, 2022
@obiot
duplicated the npm doc task so that we have one for production and on…
4ea932b 
…e local testing

instead of changing the site root back and forth until webdoc properly supports relative path.
@see webdoc-labs/webdoc#175
@ShukantPal ShukantPal mentioned this issue Jul 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obiot @ShukantPal