This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Fix jasmine wrong test result #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
…io-boneyard#94 Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
christian-bromann
suggested changes
Mar 7, 2018
test/specs/cucumber-test-case.js
Outdated
| const result = results[0] | ||
| expect(result('test-case label[name="feature"]').eq(0).attr('value')).to.equal('A passing feature') | ||
| expect(result('test-case label[name="story"]').eq(0).attr('value')).to.equal('A passing scenario') | ||
| }) | ||
| }) | ||
|
|
||
| it.only('should detect passed case', () => { |
|
Not sure why the cucumber test is failing but looks like a legit problem |
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
BorisOsipov
force-pushed
the
Fix_jasmine_test_result
branch
from
b36692b
to
010122b
Compare
|
@christian-bromann Thank you for careful review. I fixed "it.only" mistake and failed cucumber test. |
|
wdio-allure-reporter 0.4.0 published 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue
#94