Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Fix pending test reporting #127

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ class AllureReporter extends events.EventEmitter {

testPending (test) {
const allure = this.getAllure(test.cid)
if (allure.getCurrentTest()) {
if (allure.getCurrentTest() && allure.getCurrentTest().status !== 'pending') {
allure.endCase('pending')
} else {
this.getAllure(test.cid).pendingCase(test.title)
allure.pendingCase(test.title)
}
}

Expand Down
17 changes: 17 additions & 0 deletions test/fixtures/specs/several-pendings.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
const expect = require('chai').expect

describe('A pending Suite', () => {
it.skip('1. this is a skipped test without any code', function () {
})

it.skip('2. this is another skipped test without any code', function () {
})

it('3. this is an enabled test that has a successfull assert', function () {
expect('foo', 'foo should equal foo').to.contain('foo')
})

it('4. this is an enabled test that has a failed assert', function () {
expect('foo', 'foo should equal foo').to.contain('foo2')
})
})
33 changes: 33 additions & 0 deletions test/specs/test-case-pending.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { expect } from 'chai'
import { clean, runMocha } from '../helper'

describe('test cases', () => {
beforeEach(clean)

it('should detect pending test cases', () => {
return runMocha(['pending']).then((results) => {
expect(results).to.have.lengthOf(1)
const result = results[0]

expect(result('ns2\\:test-suite > name').text()).to.be.equal('A pending Suite')
expect(result('test-case > name').eq(0).text()).to.be.equal('pending test')
expect(result('test-case').eq(0).attr('status')).to.be.equal('pending')

expect(result('test-case').eq(1).attr('start')).to.be.equal(result('test-case').eq(1).attr('stop'))
})
})

it('should detect two pending test cases', () => {
return runMocha(['several-pendings']).then((results) => {
expect(results).to.have.lengthOf(1)
const result = results[0]

expect(result('test-case > name').eq(0).text()).to.be.equal('1. this is a skipped test without any code')
expect(result('test-case').eq(0).attr('status')).to.be.equal('pending')
expect(result('test-case > name').eq(1).text()).to.be.equal('2. this is another skipped test without any code')
expect(result('test-case').eq(1).attr('status')).to.be.equal('pending')
expect(result('test-case').eq(2).attr('status')).to.be.equal('passed')
expect(result('test-case').eq(3).attr('status')).to.be.equal('failed')
})
})
})
13 changes: 0 additions & 13 deletions test/specs/test-case.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,6 @@ describe('test cases', () => {
})
})

it('should detect pending test cases', () => {
return runMocha(['pending']).then((results) => {
expect(results).to.have.lengthOf(1)
const result = results[0]

expect(result('ns2\\:test-suite > name').text()).to.be.equal('A pending Suite')
expect(result('test-case > name').eq(0).text()).to.be.equal('pending test')
expect(result('test-case').eq(0).attr('status')).to.be.equal('pending')

expect(result('test-case').eq(1).attr('start')).to.be.equal(result('test-case').eq(1).attr('stop'))
})
})

it('should detect analytics labels in test case', () => {
return runMocha(['passing']).then((results) => {
expect(results).to.have.lengthOf(1)
Expand Down