Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Passing cucumber-js argument as attachment. #134

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

imdmitrykravchenko
Copy link

@jsf-clabot
Copy link

jsf-clabot commented Aug 14, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ imdmitrykravchenko
❌ v.chuchkalov


v.chuchkalov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you copying this patch to v5?

@BorisOsipov
Copy link
Contributor

@christian-bromann I am not sure it needs now (until we will have wdio-cucumber-framework v5 port)

Copy link
Contributor

@BorisOsipov BorisOsipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master. No other issues.

@BorisOsipov
Copy link
Contributor

@imdmitrykravchenko Awesome 👍

@imdmitrykravchenko
Copy link
Author

@christian-bromann yes, I will make same changes for v5 in a few days

@BorisOsipov rebased

@christian-bromann
Copy link
Contributor

christian-bromann commented Aug 16, 2018

Will merge once ported to v5. I know we haven't ported cucumber yet but it would be still great to stay consistent.

@BorisOsipov BorisOsipov closed this Oct 5, 2018
@BorisOsipov
Copy link
Contributor

Run tests

@BorisOsipov BorisOsipov reopened this Oct 5, 2018
@vchuchkalov
Copy link

@christian-bromann
very need a feature for v4

@christian-bromann
Copy link
Contributor

@vchuchkalov as we now support Cucumber v5 we need to ensure that every change that affects the old version is also added upstream to the latest version. Can you please make a similar PR to the Allure reporter in v5?

@vchuchkalov
Copy link

@christian-bromann ok, i will do it later. on next week 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants