This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Fix travis #38
Merged
Fix travis #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Open
| @@ -1,10 +1,14 @@ | |||
| language: node_js | |||
|
|
|||
| node_js: | |||
| - '4.4.3' | |||
| - 'node' | |||
There was a problem hiding this comment.
Shouldn't this suppose to be a node version?
There was a problem hiding this comment.
If you use 'node' then it just uses the latest stable node version. You can check out how this works here.
I updated this because I saw that there was a package-lock.json file, but that would be ignored by node v4. I can change this to use a fixed version if you prefer.
There was a problem hiding this comment.
BTW it seems that there are some issues with nvm on travis, I think that is why this build failed.
You can see that the exact same build went fine for me here so maybe you just need to retrigger this build to get it fixed.
|
@christian-bromann any chance of merging this? |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some PRs are stale because travis is not building properly. I forked the project and, even though the tests were running successfully locally, they were not working correctly on travis.
After a few tests, I found this article that explained how to use browsers in headless mode on travis. I tried with firefox with no success, instead with chrome it seems to be working correctly.