Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path to types.ts import #122

Merged
merged 1 commit into from
May 26, 2023

Conversation

danielrozenberg
Copy link
Contributor

@danielrozenberg danielrozenberg commented May 25, 2023

This non-relative import breaks some of the more strict type-checking systems :)

e.g.,:

build-system/tasks/e2e/node_modules/geckodriver/dist/index.d.ts:4:44 - error TS2307: Cannot find module 'types.js' or its corresponding type declarations.

4 import type { GeckodriverParameters } from 'types.js';

Copy link
Member

@vladikoff vladikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vladikoff vladikoff merged commit c54728e into webdriverio-community:main May 26, 2023
5 checks passed
@danielrozenberg danielrozenberg deleted the patch-1 branch May 26, 2023 15:37
@danielrozenberg
Copy link
Contributor Author

Thanks for the quick review!
Don't forget to publish a new npm package ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants