Fix for chrome service failing for multi remote #7055 (#58)

* Fix for chrome service failing for multi remote #7055 * Update launcher.js used logical AND operation * Added unit tests
webdriverio-community · Jun 25, 2021 · 1d90ee8 · 1d90ee8
1 parent 9cdcf11
commit 1d90ee8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/launcher.js b/src/launcher.js
@@ -21,7 +21,7 @@ const DEFAULT_CONNECTION = {
 }
 
 const isMultiremote = obj => typeof obj === 'object' && !Array.isArray(obj)
-const isChrome = cap => cap.browserName.toLowerCase() === 'chrome'
+const isChrome = cap => cap.browserName && cap.browserName.toLowerCase() === 'chrome'
 
 export default class ChromeDriverLauncher {
     constructor(options, capabilities, config) {
@@ -79,7 +79,7 @@ export default class ChromeDriverLauncher {
         process.on('uncaughtException', this.onComplete.bind(this))
     }
 
-    onComplete () {
+    onComplete() {
         if (this.process) {
             this.process.kill()
         }

diff --git a/tests/launcher.test.js b/tests/launcher.test.js
@@ -36,6 +36,11 @@ describe('ChromeDriverLauncher launcher', () => {
                 capabilities: {
                     browserName: 'firefox'
                 }
+            },
+            myCustomAppium: {
+                capabilities: {
+                    'platformName': 'android',
+                }
             }
         }
     })
@@ -200,6 +205,11 @@ describe('ChromeDriverLauncher launcher', () => {
                     capabilities: {
                         browserName: 'firefox'
                     }
+                },
+                myCustomAppium: {
+                    capabilities: {
+                        'platformName': 'android',
+                    }
                 }
             })
         })