This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add pollTimeout to options #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Bromann <git@bromann.dev>
|
Seems like some tests still fail. |
Yeah had forgotten to edit the tests also. I also separated the rest of the default values from the test cases. |
|
@christian-bromann Can you please merge this pull request ? Should I do something else regarding this PR? Because I want to create another pull request in electron service as well regarding to this issue and I'm waiting for this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Added pollTimeout to options and also readme.
Regarding #192.