Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Added ability to specify customChromeDriverLocation #60

Merged
merged 9 commits into from
Jul 12, 2021

Conversation

praveendvd
Copy link
Contributor

This allows to run electron application testing using chrome driver service by pointing to the chrome driver installed using "npm install electron-chromedriver"

@praveendvd
Copy link
Contributor Author

@christian-bromann Hi i have added option to specify customchromedriver path. So that we can point it to chromedriver installed using electron-chromedriver

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me, can we add a test to check that it is actually using the custom chromedriver binary rather than the detected one?

README.md Outdated Show resolved Hide resolved
@praveendvd
Copy link
Contributor Author

Will do that thanks @christian-bromann for looking into this

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good to me 👍

tests/launcher.test.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Contributor

Feel free to merge and release with a minor version bump (just trigger this workflow: https://github.com/webdriverio-community/wdio-chromedriver-service/actions/workflows/release.yml)

@praveendvd
Copy link
Contributor Author

@christian-bromann I am not sure if i have the rights to do it , i can't see merge or run workflow options , could you let me know how to do it , i haven't done it before

@christian-bromann
Copy link
Contributor

christian-bromann commented Jul 12, 2021

I just fixed the org structure, you should have all necessary access rights now. Please go ahead and Squash/merge this PR, then open the release workflow, click on "Run workflow" and change the first input field from patch to minor, lastly hit the green "Run workflow" button again. Let me if you have any questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants