-
-
Notifications
You must be signed in to change notification settings - Fork 26
Added ability to specify customChromeDriverLocation #60
Conversation
@christian-bromann Hi i have added option to specify customchromedriver path. So that we can point it to chromedriver installed using electron-chromedriver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense to me, can we add a test to check that it is actually using the custom chromedriver binary rather than the detected one?
Will do that thanks @christian-bromann for looking into this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good to me 👍
Feel free to merge and release with a |
@christian-bromann I am not sure if i have the rights to do it , i can't see merge or run workflow options , could you let me know how to do it , i haven't done it before |
I just fixed the org structure, you should have all necessary access rights now. Please go ahead and Squash/merge this PR, then open the release workflow, click on "Run workflow" and change the first input field from |
This allows to run electron application testing using chrome driver service by pointing to the chrome driver installed using "npm install electron-chromedriver"