Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GitHub Workflow #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seanpoulter
Copy link

@seanpoulter seanpoulter commented Mar 5, 2024

Proposed Changes

Add a GitHub Workflow

  • Add .nvmrc to document the minimum version of Node.js
  • Configure yarn:
    • Remove the hard-coded yarnPath from .yarnrc.yml so we can contribute to the repo
    • Do not use zero-install yarn
      • Follow the docs to update .gitignore
      • Remove .yarn/install-state.gz from version control
  • Configure Mocha
    • Use the bdd style so describe and it are defined
  • Fix TypeScript errors
    • Enable "skipLibCheck"
    • Remove unused variables with TypeScript errors 馃敟
  • Remove unnecessary files
    • Remove the generated test//*.js** files. They're not used.
    • Remove the "nested" test case. It doesn't test anything new.
  • Fix spelling

Test Plan

Here's an example of the Workflow results. The tests fail.
https://github.com/seanpoulter/wdio-html-reporter/actions/runs/8414054497/job/23037156333

@seanpoulter seanpoulter force-pushed the github-workflow branch 2 times, most recently from 9737d26 to ed27f6b Compare March 25, 2024 02:10
- Use the minimum supported version of Node.js
- Configure yarn and .gitignore
- Remove compiled **.js** files
- Use a consistent Mocha UI interface/style
- Remove tests that do not exercise the module's behaviour
- Resolve problems reported by TypeScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant