Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement screenshotIntervalSecs configuration option #89

Conversation

wadjei
Copy link
Contributor

@wadjei wadjei commented Dec 29, 2022

Proposal for Issue #90

Add a screenshotIntervalSecs configuration option.

Setting this will cause screenshots to be requested at regular intervals to enhance UI capturing.

Also, consolidate duplicated code to capture a frame into a single function and add debugging and tests

@wadjei
Copy link
Contributor Author

wadjei commented Dec 29, 2022

the test suite has failed because I have reinstated the sleep test. The revised test in #88 will work.

@christian-bromann
Copy link
Contributor

@wadjei please rebase your branch on top of current main so we can see the test suite passing.

Setting this will cause screenshots to be requested at regular intervals
to enhance UI capturing
@wadjei wadjei force-pushed the feature/interval-based-screenshots branch from 1b7cc4e to 285013c Compare December 30, 2022 09:53
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 031068f into webdriverio-community:main Dec 30, 2022
@wadjei wadjei deleted the feature/interval-based-screenshots branch December 30, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants