Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Expense Contribution workflow #2

Closed
wants to merge 1 commit into from

Conversation

seanpoulter
Copy link

Proposed Changes

@seanpoulter
Copy link
Author

@christian-bromann, I'm not sure if you want this change here or any other pipelines/actions.
Alternatively, we could set this up as a Starter Workflow that would let you configure and commit it to a new repo from Actions.

@christian-bromann
Copy link
Member

Do you know if adding the workflow here will propagate it automatically to all other repositories in this organisation?

Alternatively, we could set this up as a Starter Workflow

Do you think this is possible to do in webdriverio/expense-action?

@seanpoulter
Copy link
Author

Do you know if adding the workflow here will propagate it automatically to all other repositories in this organisation?

Unfortunately it doesn't propagate like that. Some folks put their reusable workflows in this directory (like this blog) but I believe we could reference it from webdriverio/expense-action as well.


Alternatively, we could set this up as a Starter Workflow

Do you think this is possible to do in webdriverio/expense-action?

The "starter workflows" have to be defined in the .github repository for the organization. Then we'd be presented with an option to add a new Workflow using the workflow template. It doesn't solve the maintenance problem though.

We could try to automate updates from webdriverio/expense-action by adding to script/. I tried using the gh CLI and it didn't like to gh pr create without prompting for user input. 🤦

@christian-bromann
Copy link
Member

christian-bromann commented Mar 1, 2024

but I believe we could reference it from webdriverio/expense-action as well.

I think we essentially doing this by referencing it as GitHub Action.

We could try to automate updates from webdriverio/expense-action by adding to script/. I tried using the gh CLI and it didn't like to gh pr create without prompting for user input. 🤦

Yeah, we could have an automated script that clones all repos, commits the given workflow and raises a PR if the workflow has changes but for now I think we can just keep everything as is. If it turns out that we tweak the workflow options a lot, it makes sense to get back to this.

Will close this PR as I don't think we need an expense flow for this particular repository, given we don't expect any non member contributions here. Thanks for all your work!

@seanpoulter seanpoulter deleted the expense-workflow branch March 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants