-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle toHaveText when receiving an array of elements #1571
Conversation
…ts and documentation accordingly
… for custom message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work , thanks so much!
🎉
Hey sangcnguyen 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Thanks for this PR , but toHaveText is not working with
with:
I have this error :
|
@lacell75 thanks for reporting. @sangcnguyen Let's make sure we can support both use cases. |
My hunch is does the code below work? I didn't know the use case of using 'expect.arrayContaining' before, so why do we need it?
|
@lacell75 mind providing more details? What do you expect to be asserted when calling await expect($('div').toHaveText(expect.arrayContaining(['text1', 'text2'])); Do you expect that |
I'm trying to take a stab at this #1555. Could you help me review it?