linter issues

webdriverio · Oct 1, 2023 · a0f2716 · a0f2716
1 parent fa60696
commit a0f2716
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/lib/driver-starter.js b/lib/driver-starter.js
@@ -33,7 +33,9 @@ async function startDriver(pathToChromeDriver, args) {
   const killChromeDriver = () => {
     try {
       chromeDriverProcess.kill();
-    } catch (ignored) {}
+    } catch (_) {
+      // eslint-disable-next-line no-empty
+    }
   };
   process.on('exit', killChromeDriver);
   process.on('SIGTERM', killChromeDriver);

diff --git a/lib/processKiller.js b/lib/processKiller.js
@@ -28,7 +28,7 @@ function getConfigProcessesName(drivers) {
 
 async function processKiller(ports, processesName) {
   if (ports && ports.length) {
-    for (let port of ports) {
+    for (const port of ports) {
       if (port) {
         const portCast = `${port}`.startsWith(':') ? port : `:${port}`;
 

diff --git a/lib/start.js b/lib/start.js
@@ -171,7 +171,8 @@ async function start(_opts) {
           .map((d) => {
             if (d === 'firefox') {
               return 4444;
-            } else if (d === 'chrome' || d === 'chromiumedge') {
+            }
+            if (d === 'chrome' || d === 'chromiumedge') {
               return 9515;
             }
           })
@@ -201,6 +202,7 @@ async function start(_opts) {
     );
 
     return chromeDriverProcess;
+    // eslint-disable-next-line no-else-return
   } else {
     const selenium = spawn(opts.javaPath, args, opts.spawnOptions);
     await checkStarted(selenium, seleniumStatusUrl.toString());

diff --git a/test/only-driver-tests.js b/test/only-driver-tests.js
@@ -8,7 +8,7 @@ const checkPathsExistence = require('../lib/check-paths-existence');
 const computeFsPaths = require('../lib/compute-fs-paths');
 const path = require('path');
 
-let opts = {
+const opts = {
   seleniumVersion: defaultConfig.version,
   seleniumBaseURL: defaultConfig.baseURL,
   drivers: defaultConfig.drivers,
@@ -21,7 +21,7 @@ describe('check onlyDriver downloading only driver without selenium server and o
     const paths = await install(testOpt);
 
     testOpt.drivers = {};
-    testOpt.drivers.chrome = opts.drivers['chrome'];
+    testOpt.drivers.chrome = opts.drivers.chrome;
 
     const fsPaths = await computeFsPaths({
       seleniumVersion: opts.seleniumVersion,
@@ -80,7 +80,9 @@ describe('check onlyDriver with certain name of driver', () => {
       await install(testOpt);
 
       assert(false);
-    } catch {}
+    } catch (_) {
+      // eslint-disable-next-line no-empty
+    }
   });
 });