Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seleniumArgs from configuration file is ignored #275

Closed
tonatiuhromero opened this issue Apr 20, 2017 · 2 comments
Closed

seleniumArgs from configuration file is ignored #275

tonatiuhromero opened this issue Apr 20, 2017 · 2 comments
Assignees

Comments

@tonatiuhromero
Copy link

Expected Behavior

If I add seleniumArgs in a configuration file it should be used if no command line arguments were provided.

i.e.
seleniumArgs: [ '-role', 'hub', '-port', '4446' ],

Current Behavior

It seems currently only the command line arguments are use and not from the configuration file.
I think the problem is in this part of selenium-standalone.js :

var seleniumArgs = argv._.slice(1);
....
// Merge default options, options from config file then command line options
options = merge({}, defaultConfig, configFromFile, options);

options.seleniumArgs = seleniumArgs;
options.spawnOptions = {
stdio: 'inherit'
};

@jucrouzet jucrouzet self-assigned this Apr 20, 2017
jucrouzet added a commit to jucrouzet/selenium-standalone that referenced this issue Apr 20, 2017
@jucrouzet
Copy link
Collaborator

Yep, the options.seleniumArgs = seleniumArgs overwrite the configuration value.
Just did a PR, waiting for a peer review, it should be fixed in next version.

jucrouzet added a commit that referenced this issue Apr 24, 2017
Handle seleniumArgs in config file ( #275 )
@jucrouzet
Copy link
Collaborator

Fixed in 6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants